Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy v0.981 causes jsonpatch-stubs error #2039

Closed
matthewfeickert opened this issue Oct 3, 2022 · 2 comments
Closed

mypy v0.981 causes jsonpatch-stubs error #2039

matthewfeickert opened this issue Oct 3, 2022 · 2 comments
Assignees
Labels
bug Something isn't working pre-commit Related to pre-commit hooks

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Oct 3, 2022

 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.971
+    rev: v0.981

is causing errors of the form

mypy with Python 3.10....................................................Failed
- hook id: mypy
- exit code: 2

Deferral trace:
    jsonpatch:98
...
...
...
/home/feickert/.cache/pre-commit/repou_tp6v3h/py_env-python3.10/lib/python3.10/site-packages/jsonpatch-stubs/__init__.pyi: error: INTERNAL ERROR: maximum semantic analysis iteration count reached
/home/feickert/.cache/pre-commit/repou_tp6v3h/py_env-python3.10/lib/python3.10/site-packages/jsonpatch-stubs/__init__.pyi:229: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
If this issue continues with mypy master, please report a bug at https://github.com/python/mypy/issues
version: 0.981
/home/feickert/.cache/pre-commit/repou_tp6v3h/py_env-python3.10/lib/python3.10/site-packages/jsonpatch-stubs/__init__.pyi:229: : note: please use --show-traceback to print a traceback when reporting a bug

I'm attaching the output of

pre-commit run mypy --all-files &> mypy-v0.981-error.txt

here: mypy-v0.981-error.txt

Originally posted by @matthewfeickert in #2038 (comment)

@matthewfeickert matthewfeickert added bug Something isn't working pre-commit Related to pre-commit hooks labels Oct 3, 2022
@kratsg
Copy link
Contributor

kratsg commented Oct 3, 2022

Must be a recursive type somewhere in the typeshed for jsonpatch?

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Oct 4, 2022

Closing as we can just get this picked up in the next mypy release that pre-commit.ci bumps us to as the underlying problem was fixed in python/mypy#13516, as noted in python/mypy#13813.

Thanks to @henryiii for the MFE though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pre-commit Related to pre-commit hooks
Projects
None yet
Development

No branches or pull requests

2 participants