We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
right now we use "twice_nll" as a fit objective and in the test statistic a simple diffence
twice_nll_constrfit - twice_nll_globalfit
but rather we should just to a NLL fit and in the test stat do
2*(nll_constrfit - nll_globalfit)
this will require updating some test reference numbers in the tests
The text was updated successfully, but these errors were encountered:
@lukasheinrich while I'm not against this, what is the primary motivation for the change?
Sorry, something went wrong.
it's more customary to fit the NLL and I think we might have slight bus re errordef in minuit because we're fitting a scaled objective
I think we might have slight bus re errordef in minuit because we're fitting a scaled objective
Good enough reason for me. 👍
I just came across this again, but the errordef being used is fine, so no bugs there.
matthewfeickert
Successfully merging a pull request may close this issue.
right now we use "twice_nll" as a fit objective and in the test statistic a simple diffence
twice_nll_constrfit - twice_nll_globalfit
but rather we should just to a NLL fit and in the test stat do
2*(nll_constrfit - nll_globalfit)
this will require updating some test reference numbers in the tests
The text was updated successfully, but these errors were encountered: