Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace axis_wrap_if_negative with maybe_posaxis, simpler and more correct #1986

Merged
merged 26 commits into from
Dec 9, 2022
Merged

fix: replace axis_wrap_if_negative with maybe_posaxis, simpler and more correct #1986

merged 26 commits into from
Dec 9, 2022

Commits on Dec 9, 2022

  1. Introduce maybe_posaxis as a replacement for axis_wrap_if_negative an… 

    …d implement ak.is_none.
    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    7b39e62 View commit details
    Browse the repository at this point in the history

  2. Use maybe_posaxis in ak.singletons.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    deb912e View commit details
    Browse the repository at this point in the history

  3. Also handle is_union case in ak.singletons.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    8a29851 View commit details
    Browse the repository at this point in the history

  4. Use maybe_posaxis in ak.firsts.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d3c54b7 View commit details
    Browse the repository at this point in the history

  5. Use maybe_posaxis in ak.unflatten.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5ddb430 View commit details
    Browse the repository at this point in the history

  6. Use maybe_posaxis in ak.from_regular.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    89c12e2 View commit details
    Browse the repository at this point in the history

  7. Use maybe_posaxis in ak.to_regular.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ccdc8ea View commit details
    Browse the repository at this point in the history

  8. ak.to_regular had been silently exceeding the array.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a8c04cd View commit details
    Browse the repository at this point in the history

  9. Protect ak.fill_none as well.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    6b1271e View commit details
    Browse the repository at this point in the history

  10. Use maybe_posaxis in ak.cartesian.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    aa42b9b View commit details
    Browse the repository at this point in the history

  11. Use maybe_posaxis in ak.flatten.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    353c780 View commit details
    Browse the repository at this point in the history

  12. Use maybe_posaxis in ak.ptp.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    0ff4ec0 View commit details
    Browse the repository at this point in the history

  13. Use maybe_posaxis in ak.concatenate.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    cb5e490 View commit details
    Browse the repository at this point in the history

  14. The 'num' function actually takes 'depth minus 1'.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    9fd558c View commit details
    Browse the repository at this point in the history

  15. Replace 'Content._num' with a 'recursively_apply' implementation and … 

    …eliminate the weird axis=0 output for records.
    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    6cbb2bc View commit details
    Browse the repository at this point in the history

  16. Shift Content._offsets_and_flattened to use the standard 'depth' defi… 

    …nition.
    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3b2aadc View commit details
    Browse the repository at this point in the history

  17. Content._offsets_and_flattened now uses maybe_posaxis.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    6d0beb8 View commit details
    Browse the repository at this point in the history

  18. Shift Content._local_index to use the standard 'depth' definition.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a2b8120 View commit details
    Browse the repository at this point in the history

  19. Content._local_index now uses maybe_posaxis.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a00073f View commit details
    Browse the repository at this point in the history

  20. Shift Content._pad_none to use the standard 'depth' definition.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    f6af253 View commit details
    Browse the repository at this point in the history

  21. Content._pad_none now uses maybe_posaxis.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    8943e17 View commit details
    Browse the repository at this point in the history

  22. Shift Content._combinations to use the standard 'depth' definition.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    82d196d View commit details
    Browse the repository at this point in the history

  23. Content._combinations now uses maybe_posaxis.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3b84fec View commit details
    Browse the repository at this point in the history

  24. Delete axis_wrap_if_negative and move maybe_posaxis to _util.

    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    08f4c40 View commit details
    Browse the repository at this point in the history

  25. Reenterant calling recursively_apply resets depth; this idiom is simp… 

    …ler and correct for deep unions.
    @jpivarski
    jpivarski committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    18d7a7d View commit details
    Browse the repository at this point in the history

  26. Update tests/test_1137-num.py

    @agoose77
    agoose77 authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d73d78a View commit details
    Browse the repository at this point in the history