Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ak2 convert class name msg #1544

Merged
merged 1 commit into from
Jul 18, 2022
Merged

fix ak2 convert class name msg #1544

merged 1 commit into from
Jul 18, 2022

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Jul 11, 2022

>>> ak.to_list(arr)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/akako/Documents/github/dotFiles/homedir/.julia/conda/3/lib/python3.9/site-packages/awkward/operations/convert.py", line 1002, in to_list
    raise TypeError("use ak._v2.operations.convert.to_list for v2 arrays (for now)")
TypeError: use ak._v2.operations.convert.to_list for v2 arrays (for now)
>>> ak._v2.operations.convert.to_list(arr)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'awkward._v2.operations' has no attribute 'convert'
>>> ak._v2.operations.to_list(arr)
[{'one_integers': 3, 'two_v_floats': [1.2000000476837158], 

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1544 (99713bd) into main (78a6535) will decrease coverage by 0.12%.
The diff coverage is 60.81%.

Impacted Files Coverage Δ
src/awkward/_v2/contents/indexedoptionarray.py 89.14% <54.54%> (-0.70%) ⬇️
src/awkward/_v2/highlevel.py 70.77% <57.60%> (-2.76%) ⬇️
src/awkward/_v2/_connect/numba/arrayview.py 96.76% <100.00%> (ø)
src/awkward/_v2/contents/content.py 76.61% <100.00%> (ø)
src/awkward/_v2/operations/ak_copy.py 100.00% <100.00%> (ø)
src/awkward/_v2/operations/ak_is_none.py 96.55% <100.00%> (+0.39%) ⬆️
src/awkward/_v2/record.py 76.86% <100.00%> (-0.18%) ⬇️
src/awkward/_v2/types/recordtype.py 86.72% <100.00%> (-0.35%) ⬇️
src/awkward/_v2/types/numpytype.py 88.09% <0.00%> (-1.20%) ⬇️
src/awkward/_v2/operations/ak_type.py 53.84% <0.00%> (+2.56%) ⬆️

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this corrects the error message, so that it doesn't recommend a function that doesn't exist. (It could also have been "ak._v2.to_list, but it's temporary, anyway.)

@jpivarski jpivarski enabled auto-merge (squash) July 18, 2022 15:27
@jpivarski jpivarski merged commit b620428 into scikit-hep:main Jul 18, 2022
@jpivarski
Copy link
Member

Hi Jerry! I know this is a small thing, from 2 years ago now, but I'm sorry I forgot to add your name to the all-contributors list!

@all-contributors please add @Moelf for doc

Copy link
Contributor

@jpivarski

I've put up a pull request to add @Moelf! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants