Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array builder with new growable buffer #1529

Closed
wants to merge 3 commits into from

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Jul 5, 2022

thorough testing of a GrowableBuffer from #1494

@ianna ianna marked this pull request as draft July 5, 2022 15:36
@ianna ianna mentioned this pull request Jul 5, 2022
15 tasks
@ianna
Copy link
Collaborator Author

ianna commented Jul 6, 2022

pre-commit fails with:

src/awkward/_v2/_connect/numba/arrayview.py:666:35: B023 Function definition does not bind loop variable 'typer'.
src/awkward/_v2/_connect/numba/arrayview.py:671:33: B023 Function definition does not bind loop variable 'methodname'.
src/awkward/_v2/_connect/numba/arrayview.py:679:31: B023 Function definition does not bind loop variable 'lower'.
src/awkward/_connect/_numba/arrayview.py:910:35: B023 Function definition does not bind loop variable 'typer'.
src/awkward/_connect/_numba/arrayview.py:915:33: B023 Function definition does not bind loop variable 'methodname'.
src/awkward/_connect/_numba/arrayview.py:923:31: B023 Function definition does not bind loop variable 'lower'.
tests/test_0057b-virtual-array-numba.py:77:13: B023 Function definition does not bind loop variable 'counter'.
tests/test_0057b-virtual-array-numba.py:78:20: B023 Function definition does not bind loop variable 'layout'.

@jpivarski
Copy link
Member

Those tests were fixed by #1533, which you can now use by merging with main (#1533 has been merged into main).

@ianna ianna force-pushed the ianna/array-builder-with-new-growable-buffer branch from f325ca2 to 7092544 Compare July 7, 2022 10:36
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1529 (1e09a91) into main (78a6535) will decrease coverage by 0.11%.
The diff coverage is 57.93%.

❗ Current head 1e09a91 differs from pull request most recent head 2f277fa. Consider uploading reports for the commit 2f277fa to get more accurate results

Impacted Files Coverage Δ
src/awkward/_v2/highlevel.py 70.77% <57.60%> (-2.76%) ⬇️
src/awkward/_v2/_connect/numba/arrayview.py 96.76% <100.00%> (ø)

@ianna ianna force-pushed the ianna/array-builder-with-new-growable-buffer branch from 7092544 to 76a6b69 Compare July 7, 2022 11:20
@ianna ianna closed this Jul 7, 2022
@ianna ianna reopened this Jul 7, 2022
@ianna ianna force-pushed the ianna/array-builder-with-new-growable-buffer branch from 1e09a91 to 2f277fa Compare July 7, 2022 11:46
@ianna
Copy link
Collaborator Author

ianna commented Jul 11, 2022

replaced by #1542

@ianna ianna closed this Jul 11, 2022
@ianna ianna deleted the ianna/array-builder-with-new-growable-buffer branch September 1, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants