-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add missing _like
methods to TypeTracer
#1505
Conversation
We should accept `None`
for more information, see https://pre-commit.ci
The modified At this point I think we need to decide how flexible
My thought is to keep it restricted for now. |
Codecov Report
|
…at-typetracer-missing # Conflicts: # src/awkward/_v2/_typetracer.py
This function creates TypeTracerArrays from NumPy arrays to act as buffers within an Awkward Array, so they need to be the kinds of NumPy arrays that can be buffers in an Awkward Array. Those NumPy arrays can't have Is this PR done? It looks done, and I'd like to make a new release very soon (definitely by tomorrow). Why did you remove the |
@jpivarski my concern was if we use it internally for anything: I recall doing
|
I'm sorry to hear that—I hope you feel better soon! I think The But that's okay; I think that's minor. Thanks for the new methods and I'll include them in the pre-release! |
Thanks @agoose77! edit: I had originally pointed out a new issue with |
This PR just implements some of the missing
TypeTracer
methods to fix #1504Changes:
unset
fromTypeTracer
signatures - we should support explicitNone
from_array
to handle literal sequence of primitives_like
methods