Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: ak.broadcast_arrays #1368

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Mar 13, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #1368 (768b292) into main (b2fd2be) will increase coverage by 0.07%.
The diff coverage is 56.89%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/cling.py 0.00% <0.00%> (ø)
src/awkward/_v2/_connect/pyarrow.py 85.74% <0.00%> (ø)
src/awkward/_v2/_lookup.py 97.50% <0.00%> (ø)
src/awkward/_v2/_prettyprint.py 66.09% <0.00%> (+2.29%) ⬆️
src/awkward/_v2/_typetracer.py 69.14% <0.00%> (ø)
src/awkward/_v2/forms/form.py 90.06% <0.00%> (ø)
src/awkward/_v2/identifier.py 55.69% <0.00%> (ø)
src/awkward/_v2/index.py 83.59% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_jax.py 75.00% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_to_jax.py 75.00% <0.00%> (ø)
... and 146 more

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great as-is, but maybe move test_broadcast_arrays before pytest.importorskip("numexpr") to make sure it gets tested (this one only depends on NumPy, not numexpr).

Go ahead and merge when ready.

@ioanaif ioanaif merged commit 922b727 into main Mar 15, 2022
@ioanaif ioanaif deleted the ioanaif/ak.broadcast_arrays branch March 15, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants