Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: getting Numba to work for v2 arrays #1240

Merged
merged 28 commits into from
Feb 5, 2022

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Jan 20, 2022

Tests of Numba to convert:

  • test_0056b-partitioned-array-numba.py no more partitioned arrays
  • test_0057b-virtual-array-numba.py no more virtual arrays
  • test_0124-strings-in-numba.py
  • test_0127b-tomask-operation-numba.py
  • test_0290-bug-fixes-for-hats.py
  • test_0390-virtual-forms.py no more virtual arrays
  • test_0395-fix-numba-indexedarray.py
  • test_0494-numba-array-contains.py
  • test_0549-numba-array-asarray.py
  • test_0559-fix-booleans-in-numba.py
  • test_0572-numba-array-ndim.py
  • test_0776-numba-booleans-in-virtual-array.py no more virtual arrays
  • test_0871-nested-virtual-in-numba.py no more virtual arrays
  • test_0903-ArrayView-expects-contiguous-NumpyArrays.py

Need to implement ArrayBuilder in Numba for these:

  • test_0118-numba-cpointers.py
  • test_0397-arrays-as-constants-in-numba.py

Need to implement matrix multiplication for these (another PR):

  • test_0521-matrix-multiplication.py
  • test_0846-matrix-multiplication-numpy.py

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1240 (06b933e) into main (8e68200) will increase coverage by 1.70%.
The diff coverage is 79.39%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/numba/arrayview.py 96.24% <ø> (ø)
src/awkward/_v2/_connect/numba/layout.py 87.01% <ø> (ø)
src/awkward/_v2/contents/bytemaskedarray.py 81.09% <9.09%> (-1.96%) ⬇️
src/awkward/_v2/contents/indexedarray.py 59.17% <10.00%> (-1.47%) ⬇️
src/awkward/_v2/contents/unmaskedarray.py 55.25% <20.00%> (-0.83%) ⬇️
src/awkward/_v2/operations/io/ak_to_json_file.py 47.05% <43.75%> (-27.95%) ⬇️
src/awkward/_v2/contents/emptyarray.py 69.14% <50.00%> (-0.23%) ⬇️
src/awkward/_v2/forms/emptyform.py 77.35% <50.00%> (-1.08%) ⬇️
src/awkward/_v2/contents/content.py 81.59% <58.33%> (-0.47%) ⬇️
src/awkward/_v2/contents/regulararray.py 81.97% <58.82%> (-0.88%) ⬇️
... and 37 more

@jpivarski jpivarski marked this pull request as draft January 20, 2022 23:45
@jpivarski jpivarski marked this pull request as ready for review February 5, 2022 00:26
@jpivarski jpivarski enabled auto-merge (squash) February 5, 2022 00:28
@jpivarski jpivarski merged commit 13361fd into main Feb 5, 2022
@jpivarski jpivarski deleted the jpivarski/v2-implementation-of-numba-1 branch February 5, 2022 00:56
@jpivarski jpivarski changed the title Getting Numba to work for v2 arrays C++ refactoring: getting Numba to work for v2 arrays Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant