-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against NumPy 2.0 #2936
Comments
NumPy 2.0's release notes serve as a migration guide, and their umbrella issue, numpy/numpy/issues/24300, is a good source of news. |
The development wheels are here: https://anaconda.org/scientific-python-nightly-wheels/numpy! |
Some potential concern was raised at pybind/pybind11#5050 (comment) about Awkward Array using structured dtypes, which are a potential hiccup in |
Hmm, I'm not sure what @henryiii is exactly saying in pybind/pybind11#5050. AFAICR, we don't inherently use any C structs via NumPy structured dtypes. But, perhaps I'm forgetting. @jpivarski might recall. I believe I've tested locally against a NumPy 2.0 pre/dev-release, and didn't spot anything. |
The change only landed in NumPy quite recently from what I understand. If you didn’t have to use a pybind11 branch, it shouldn’t have worked, I believe (regardless of if any custom dtypes are used). It might be that all structured types are handled by the forth layer? Anyway, I’ll try to test with boost-histogram, which uses structured dtyoes for the weighed and mean storages. |
Indeed, last Thursday or so.
|
We have not tested with the nightly NumPy releases, and clearly we need to. On the point about structured dtypes, we don't use them in any pybind11 calls. The closest that Awkward Array gets to structured dtypes is that this is an output type of |
Ruff has tools for this, and there are NumPy 2.0 prereleases (or there will be soon).
The text was updated successfully, but these errors were encountered: