Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFTW should be a dependency #16

Open
leofang opened this issue Apr 7, 2020 · 2 comments
Open

FFTW should be a dependency #16

leofang opened this issue Apr 7, 2020 · 2 comments

Comments

@leofang
Copy link

leofang commented Apr 7, 2020

I think after #7 for pip install to work we need the presence of FFTW. We'll need a mechanism to detect FFTW headers at build time (similar to how pybind11 is handled). For conda recipe it's easy (just set fftw to be a build dependency), but I'm not sure how to cleanly resolve this for PyPI packaging...

@tacaswell
Copy link
Member

There is a setup_requires field that mostly works. You can also go down the pyproject.toml / flit route.

@leofang
Copy link
Author

leofang commented Apr 7, 2020

If FFTW is not found, pip install from PyPI should just fail (as it does now), right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants