You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's issues in the relationship between IIIF Print, AV, and Hyku. For now this is a place holder for future way finding.
There is a conflict between the IiifPrint and Hyrax::IiifAv gems;
namely they both have strong opinions about how to sniff out if we
should use the iiif_viewer?. Compounding this, is that IiifPrint
decorates Hyrax::WorkShowPresenter and Hyku extends Hyrax::WorkShowPresenter then includes Hyrax::IiifAv::DisplaysIiifAv.
The end result is that the logic to determine if we should show pages
split from the PDF is never called. Yet, if we were to solely use
IiifPrint we'd ignore rendering audio and vidoe in the iiif viewer.
So this commit peels that back so that we're using the logic (brought
forward by IiifPrint) but ensuring our Hyku presenters are using that
logic.
Why move the logic out of the Hyku instance and into a module? Because
that module contains the per-tenant antics of IiifPrint and its PDF
relationship.
There is larger work to do in regards to incorporating this logic into
IiifPrint and the Hyrax::IiifAv gem.
There's issues in the relationship between IIIF Print, AV, and Hyku. For now this is a place holder for future way finding.
Related to:
The text was updated successfully, but these errors were encountered: