Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate, empty instantiation Location (and other properties) getting saved when they should't be #141

Open
ekemeyer opened this issue Aug 13, 2024 · 0 comments

Comments

@ekemeyer
Copy link
Collaborator

To replicate

  1. Go to an "Edit Instantiation" interface where the instantiation has at least one value for Location already.
  2. Without editing anything at all , click the save button.
  3. Navigate back to the parent asset's details page, and view it's PBCore by adding the ".xml" to the URL.

Expected result

The PBCore XML should not have an additional <instantiationLocation> element

Actual result

The PBCore XML has an additional <instantiationLocation> element.

Background

  1. This additional element is invalid PBCore and thus causes a failure when trying to ingest to AAPB.
  2. The instantiation location should not be multivalued, so it should not even have the option to add multiple locations like this.
  3. But also, the input field used for adding multiple values should not be saving additional empty ones by default when the user doesn't even do anything except hit the save button.

Done when

  1. The form input for multi-valued fields is not saving empty values
  2. Instantiation properties that are not multi-valued are not using the multi-value form input.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant