Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request access for DIPY #45

Closed
skoudoro opened this issue Nov 22, 2023 · 14 comments
Closed

Request access for DIPY #45

skoudoro opened this issue Nov 22, 2023 · 14 comments

Comments

@skoudoro
Copy link
Contributor

skoudoro commented Nov 22, 2023

Hi Scientific Python Team,

Please allow uploading the DIPY wheel packages to the nightly build site. We are currently building our wheels in this repo: https://github.com/MacPython/dipy-wheels

Thank you

EDIT: we might switch to cibuildwheel next year.

@matthewfeickert
Copy link
Member

matthewfeickert commented Nov 22, 2023

@skoudoro has this been discussed with the SPEC Steering Committee? Currently I believe that only packages that are defined as "core" are being given upload permissions to the channel (c.f. #30 (comment) and Issue #29).

@stefanv
Copy link
Member

stefanv commented Nov 22, 2023

@skoudoro Are there many packages that depend on a DiPy wheel for testing? That may be motivation to include it.

@skoudoro
Copy link
Contributor Author

@skoudoro has this been discussed with the SPEC Steering Committee?

No, I did not know that I need to do a request to the steering commitee first

Currently I believe that only packages that are defined as "core" are being given upload permissions to the channel (c.f. #30 (comment) and Issue #29).

ok, thank you for letting me know. I believed it was for all scientific package and an alternative to the previous one https://anaconda.org/scipy-wheels-nightly/ where we had our nightly build.

@skoudoro Are there many packages that depend on a DiPy wheel for testing? That may be motivation to include it.

Not sure, about that, when I look at the download of our previous nightly build repo, it seems only few packages were using it: https://anaconda.org/scipy-wheels-nightly/dipy/files.

@skoudoro
Copy link
Contributor Author

Thank you @matthewfeickert, I will read the thread.

Also, what do you recommend as an alternative for now @matthewfeickert and @stefanv ?

@martinfleis
Copy link
Member

I may not be up to speed with the recent discussions but original idea was not limited to core projects. We wanted to replace the scipy nightly channel so any package that is compiled and used by a wider community could be included.

@stefanv
Copy link
Member

stefanv commented Nov 22, 2023

While we should clarify the scope of the SPEC, we should also be pragmatic and flexible and do whatever is useful to the community. @skoudoro So you know, your request is totally valid, and it falls on us to clarify the parameters here.

FWIW, re: the term "core projects": it was a useful idea to get the project going, but we're trying to move away from it and towards a notion of "every project actively participating in the process and conversation". The idea was always to involve the wider community, not to use it for exclusion.

Let's also get some input from some of the other SPEC authors, who will be more familiar with the conversation; @bsipocz @jarrodmillman et al. Note that it's thanksgiving in the US, so we may only hear back next week.

@skoudoro
Copy link
Contributor Author

No worries and thank you for clarifying. I understand also the anaconda space challenge.

For now, I will go ahead and use github as a nightly wheels storage like cython project.

I am closing this issue since I feel it is a duplicate of #29 and #30.

Just keep me updated if there is some progress concerning this point.

Thank you all and Happy thanksgiving week!

@matthewfeickert
Copy link
Member

matthewfeickert commented Nov 22, 2023

@skoudoro I'm going to leave this open so that (and until) the SPEC authors can respond here (unless @bsipocz and @jarrodmillman want to continue this discussion where it originally started in Issue #29 or was moved to in Issue #30).

@jarrodmillman
Copy link
Member

The main issue is how much space anaconda is willing to give us. I asked a friend whether they could ask for more space since they know people at anaconda. I will make another request and see if we can get more space.

@betatim
Copy link
Contributor

betatim commented Nov 23, 2023

Modulo space limits (I didn't realise there was a limit) I'd say that in general all packages that have a track record of being maintained and used should be eligible.

@jarrodmillman
Copy link
Member

jarrodmillman commented Nov 23, 2023

2023-11-23T05:57:19,257587432-08:00

The space needs of packages varies a lot. For example, openblas-libs is using 2.4GB, while ipython and networkx combined use less than 3MB.

@matthewfeickert
Copy link
Member

matthewfeickert commented Feb 23, 2024

@skoudoro Good news, we have the approval (#30 (comment)) to add dipy to the nightly wheels Anaconda Cloud org https://anaconda.org/scientific-python-nightly-wheels/ !

To get started on this can you please do the following:

Steps to gain upload access to https://anaconda.org/scientific-python-nightly-wheels/

image

As you're already using the scientific-python/upload-nightly-action GitHub Action the only thing that you need to do is to make sure that you have a personal API key, and then make a PR to change where the action is uploading by removing the dipy org argument. 👍

If you have any questions please just ask here!

@skoudoro
Copy link
Contributor Author

That's a great news! thank you for following up with that!

I will do it a bit later today and keep you updated.

Thanks!

@skoudoro
Copy link
Contributor Author

all good, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants