Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Packaging tutorial #344

Closed
edsq opened this issue Dec 19, 2023 · 2 comments
Closed

Typo in Packaging tutorial #344

edsq opened this issue Dec 19, 2023 · 2 comments

Comments

@edsq
Copy link
Contributor

edsq commented Dec 19, 2023

Thanks for this nice collection of wisdom!

In the Packaging tutorial here, the __init__.py and refraction.py files are placed in the wrong directory, under src instead of src/example. The tree output of the file structure is correct, however.
@henryiii
Copy link
Collaborator

Also found in #340. No one has fixed it yet, I can soon. The GitHub Actions artifact v4 major changes has been eating up time.

@edsq
Copy link
Contributor Author

edsq commented Dec 19, 2023 •
edited
Loading

Woops, sorry for the duplicate! I can open a pull request shortly with a fix, if it is as simple as it looks.

@edsq edsq closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
@edsq edsq mentioned this issue Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henryiii @edsq