Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing comma after list of authors / reviewers #24

Closed
stefanv opened this issue Sep 22, 2023 · 1 comment · Fixed by #28
Closed

Trailing comma after list of authors / reviewers #24

stefanv opened this issue Sep 22, 2023 · 1 comment · Fixed by #28

Comments

@stefanv
Copy link
Member

stefanv commented Sep 22, 2023

Should be ','.join(authors).

May be better to format as a list instead?

@lagru lagru added the type: Bug fix Fixes to broken behavior label Sep 23, 2023
@lagru
Copy link
Member

lagru commented Sep 23, 2023

Yeah. I think this was the result of me trying to implement the formatter as a line wise generator. Looking back that was probably overengineering on my part that just makes the code more complicated and leads to things such as this being harder / forgotten.

@lagru lagru removed the type: Bug fix Fixes to broken behavior label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants