Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap to v4 #414

Closed
26 of 29 tasks
schoero opened this issue Sep 10, 2023 · 3 comments
Closed
26 of 29 tasks

Roadmap to v4 #414

schoero opened this issue Sep 10, 2023 · 3 comments

Comments

@schoero
Copy link
Owner

schoero commented Sep 10, 2023

This issue is meant to summarize the planned changes for v4 and track its progress.

Goals:

Todo:

  • Don't directly extend PDFKit. Instead create a new QRBill class that attaches to an existing PDFKit instance. External QRBill class #386 (comment).
  • Create a separate Table class for the addTable() function, that attaches to an existing PDFKit instance.
  • Keep an existing SwissQRBill class, that extends both of the other classes, as well as PDFKit for backwards compatibility.
  • Autogenerate changelog
  • Improve testing
  • Autogenerate documentation.
  • General cleanup:
    • Improve TypeScript typings.
    • Rename repository to lowercase swissqrbill
    • Rename master branch to main
  • Update how to guide
  • Create comprehensive migration guide for all users
    • users of prebuilt bundle.
    • users of html script tag.
    • users of PDF events.
    • users with custom bundling.
    • users of common js module.
@schoero schoero pinned this issue Sep 10, 2023
This was referenced Sep 11, 2023
Merged
@skch-17
Copy link

skch-17 commented Sep 26, 2023

@schoero Just wanted to let you know that currently in v4 the addContent (swissCrossBackground and scissors) seams not to work. At least in my version. I changed it back to doc.path and it worked again. Careful the strings are not an svg path they need to be replaced as well. (Master branch has the right thing)

@schoero
Copy link
Owner Author

schoero commented Sep 26, 2023

Thanks for pointing that out @skch-17. We switched to addContent for performance reasons #384. But the scissors and swiss cross contained invalid data. I have fixed it now and also improved the testing behavior, so that this kind of problems will be caught in future.

@schoero
Copy link
Owner Author

schoero commented Nov 10, 2023

SwissQRBill v4.0.0 is now finally released 🎉

@schoero schoero closed this as completed Nov 10, 2023
@schoero schoero unpinned this issue Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants