Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript: URLs not filtered out properly #49

Closed
ryan-copperleaf opened this issue Dec 21, 2017 · 4 comments
Closed

javascript: URLs not filtered out properly #49

ryan-copperleaf opened this issue Dec 21, 2017 · 4 comments

Comments

@ryan-copperleaf
Copy link

Posting it here because it’s not really a risk. One bypass:

[foo][1]

  [1]: javascript:alert(1)

The important thing is the uppercase X. Working:

Screenshot of alert(1) in live comment

@gka
Copy link
Member

gka commented Dec 21, 2017

from what I see this is still an open issue in marked, but it seems the folks over there are finally on track to fix it. will give this a few more days, if nothing happens here we'll switch to a different markdown renderer.

@styfle
Copy link

styfle commented Dec 21, 2017

See markedjs/marked#587 (comment)

@Feder1co5oave
Copy link

Feder1co5oave commented Jan 2, 2018

This was fixed in markedjs/marked#976

@g-div
Copy link
Member

g-div commented Jan 3, 2018

Fixed, thanks!

@g-div g-div closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants