Implement .click(x,y) to enable clicking at x, y coordinates

[AdamCanady]

For applications where a click can be more specific than a single DOM element, does chromeless support clicks at x,y coordinates or could someone provide a pointer to how this could be implemented (happy to send a PR if you can help me get started)?

Thanks!

[adieuadieu]

Hi @AdamCanady — This isn't implemented yet. But we'd be happy to accept a PR! It might be a good first feature to implement for a first-time contributor. You could extend the .click() method to accept x,y coordinates. You can take a look at the .wait() method for how to support multiple function signatures, and then take a the .click() method itself on how to click at a specified location. Essentially, you just need to extend the existing .click() util function to skip the getClientRect() lookup if x,y coordinates are already provided. You might need to add a check to confirm that the x,y are within the document width/height within the local-runtime.js's .click implementation.

[AlexzanderFlores]

I would love this feature! Any news on if it is being worked on?

[JimLynchCodes]

Hey, I'd really need this feature as well! I'm going to try to do the whole clone + npm link thing and try to implement this. No promises, though! :)

[JimLynchCodes]

Btw I tried this, but it didn't work:

.evaluate(() => {
  document.elementFromPoint(200, 300).click();
})

[JimLynchCodes]

Hey @adieuadieu,
I am trying to following the directions in the README, but I don't think my test project is using the cloned version of chromeless. I cloned chromeless, ran npm install and _npm link, and then made a test project in which I run npm link chromeless. It seems all good, the output I get from npm link is:

> [email protected] install /Users/jameslynch/Git-Projects/chromeless/node_modules/fsevents
> node install

[fsevents] Success: "/Users/jameslynch/Git-Projects/chromeless/node_modules/fsevents/lib/binding/Release/node-v57-darwin-x64/fse.node" already installed
Pass --update-binary to reinstall or --build-from-source to recompile
added 18 packages, removed 11 packages and updated 300 packages in 43.028s
/Users/jameslynch/.nvm/versions/node/v8.9.1/lib/node_modules/chromeless -> /Users/jameslynch/Git-Projects/chromeless

and from npm link chromeless:

/Users/jameslynch/chromeless-test/node_modules/chromeless -> /Users/jameslynch/.nvm/versions/node/v8.9.1/lib/node_modules/chromeless -> /Users/jameslynch/Git-Projects/chromeless

However, when I run my test projectI get an error that it can't find chromeless:

chromeless-test ♘ node test.js 
module.js:538
    throw err;
    ^

Error: Cannot find module 'chromeless'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/jameslynch/chromeless-test/test.js:1:86)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)

[adieuadieu]

@JimTheMan you likely need to run npm run build within your cloned chromeless repository to build the TypeScript code to Javascript.

[JimLynchCodes]

Hey thanks @adieuadie. I didn't realize I had top run npm run build again in the chromeless terminal each time a made a change. It's working now and I can see console.log's. :)

[JimLynchCodes]

I like the PR template. :)

My code isn't working, but I think it's close. I opened a PR so you guys could look at it and maybe let me know if I'm on the right track.

Also, the original function signature for click was export async function click(client: Client, selector: string, scale: number)

But can you explain a little what is client and where is that coming from? Thanks. :)

[skiloop]

Instead of click absolute coordinates, I try to implement with relative position.
for example:
click(selector, x, y)
here i create a PR #426