Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of Wire library. #58

Open
Koepel opened this issue Sep 20, 2018 · 0 comments
Open

Usage of Wire library. #58

Koepel opened this issue Sep 20, 2018 · 0 comments

Comments

@Koepel
Copy link

Koepel commented Sep 20, 2018

In the file "control-tower/weatherbox_firmware/tests/Sensor_Code/sensors.cpp", in the function d_Sensors_sampleSolarIrrmV(), the functions to read and write data via I2C are mixed together.

In the file "control-tower/weatherbox_firmware/lib/HIH613x/HIH613x.cpp", in the function dataFetch(), there are two Wire.endTransmission(), but those can be removed.
The Wire.endTransmission() may not be used to clear the bus or close something. It is only used when writing data.

By including the file "control-tower/weatherbox_firmware/lib/Adafruit_BMP085/Adafruit_BMP085.cpp", you have also included this issue: adafruit/Adafruit-BMP085-Library#17

In the file "control-tower/weatherbox_firmware/src/gen_dragonfruit/gd_dev_apogee_SP215_irradiance.cpp", in the function gd_dev_apogee_SP215_irradiance_read(), the Wire.beginTransmission() and Wire.endTransmission() should be removed. They may not be used together with Wire.requestFrom().

See my alternative explanation of the Wire functions and the Common mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant