Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement - "Adjust colour contrast for dropdown menu links" #101

Closed
mxuwku opened this issue Dec 16, 2019 · 0 comments · Fixed by #135
Closed

Improvement - "Adjust colour contrast for dropdown menu links" #101

mxuwku opened this issue Dec 16, 2019 · 0 comments · Fixed by #135
Assignees
@mmexvr
Labels
Improvement Improvement made

Comments

@mxuwku
Copy link

mxuwku commented Dec 16, 2019

Describe current situation
Dropdown textlinks are has too low contrast ratio (Aa 2.88) and might make the text hard to read for some users. _

Describe the improvement
_Change text colour from #94999d to #53565A to improve contrast ratio to Aa 7.38.

If applicable, please provide steps to reproduce
Steps to reproduce the behavior:

  1. Go to 'https://scania.github.io/corporate-ui-site/components/dropdowns'
  2. Click on 'A dropdown button'

Screenshots
Currently
image

Suggested change
image
@mxuwku mxuwku added the Improvement Improvement made label Dec 16, 2019
@mmexvr mmexvr self-assigned this Apr 15, 2020
@mmexvr mmexvr mentioned this issue Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmexvr mmexvr

Labels
Improvement Improvement made
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dropdown text colour changed scania/scania-theme
2 participants
@mmexvr @mxuwku