Reset approval status for PRs after new changes are added

[adarean5]

I pushed changes to a PR that was already approved and I noticed that the approval status persisted even after my changes were pushed. In my case, the changes were due to me rebasing my branch with the latest developed branch. Since this is an open-source project, someone could get the PR approved and then sneak in some last-minute minor changes that would not be reviewed. This would most likely be accidental, but it could also be intentional.

The one downside is that PRs would often need to be re-approved if the changes are caused by resolving minor conflicts with the target branch. On the other hand, even conflict resolution can introduce unintended changes that could be caught by a review.

I'm not that familiar with the PR settings in GitHub, but GitLab allows you to toggle whether or not approvals for PRs are reset after new changes are pushed, so perhaps GitHub has a similar setting.

[theJohnnyMe]

Good point, I will speak with team about it. It adds to security for sure, but it might slow us too. Lets see if there is an option that rebase od develop is not asking a need for re-review the code again.

[timrombergjakobsson]

I think this makes sense to have as a setting. As you said, this is a open source project, with quite a few users potentially affected if something would "sneak in". I think there is a setting called "Dismiss stale pull request approvals when new commits are pushed" that can be enabled. I think it is worth trying out, @theJohnnyMe!