Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaultclient update to allow usage of superadmin APIs without superadmin credentials #411

Draft
wants to merge 20 commits into
base: development/8.3
Choose a base branch
from

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Aug 19, 2022

With a test file used to try out the changes (PoC), just for reference, won't be merged.

Output:

[OK] ListAccounts account
[OK] CreateAccount account
[OK] GetAccount account
[OK] CheckPermissions oidc_storage_manager
[OK] GetAccount oidc_storage_manager
[OK] CheckPermissions oidc_storage_account_owner
[OK] GetAccount oidc_storage_account_owner
[OK] CheckPermissions oidc_data_consumer
[OK] GetAccount oidc_data_consumer
[OK] CreateAccount oidc_storage_account_owner
[OK] CreateAccount oidc_data_consumer
[OK] ListAccounts storage_manager
[OK] ListAccounts admin
[OK] ListAccounts storage_account_owner
[OK] GetAccount admin
[OK] ListAccounts oidc_storage_manager
[OK] CheckPermissions admin
[OK] ListAccounts data_consumer
[OK] CreateAccount storage_account_owner
[OK] CreateAccount data_consumer
[OK] CreateAccount storage_manager
[OK] CheckPermissions account
[OK] GetAccount data_consumer
[OK] GetAccount storage_manager
[OK] GetAccount storage_account_owner
[OK] CheckPermissions storage_manager
[OK] CheckPermissions data_consumer
[OK] CheckPermissions storage_account_owner
[OK] CreateAccount oidc_storage_manager
[OK] CreateAccount admin
[OK] ListAccounts oidc_storage_account_owner
[OK] ListAccounts oidc_data_consumer

@williamlardier williamlardier added the WIP Work in progress label Aug 19, 2022
@bert-e
Copy link
Contributor

bert-e commented Aug 19, 2022

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 19, 2022

Missing Jira issue

It is mandatory to specify a Jira issue in the source branch name
in order to merge into development/8.3. The issue key must follow
the prefix of the branch.

I could not find such an issue in feature/VLTCLT-test-support-role-in-superadmin-apis.

@williamlardier williamlardier changed the title Vaultclien tupdate to get rid of admin credentials in Vault Vaultclient update to get rid of admin credentials in Vault Aug 19, 2022
@williamlardier williamlardier changed the title Vaultclient update to get rid of admin credentials in Vault Vaultclient update to allow usage of superadmin APIs without superadmin credentials Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants