COSI-43: add smoke test for helm install and update a CI step name #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 75.52% 75.52%
=======================================
Files 4 4
Lines 237 237
=======================================
Hits 179 179
Misses 51 51
Partials 7 7 ☔ View full report in Codecov by Sentry. |
anurag4DSB
force-pushed
the
feature/COSI-43-add-smoke-test-for-helm-install
branch
2 times, most recently
from
ed2dcef
to
8efb310
Compare
|
rebased and updated commits |
anurag4DSB
force-pushed
the
feature/COSI-43-add-smoke-test-for-helm-install
branch
from
64abb62
to
3474fbc
Compare
|
updated helm action version from 1 to 4.2.0(caught by github UI/CI) |
BourgoisMickael
approved these changes
Nov 14, 2024
anurag4DSB
force-pushed
the
feature/COSI-33-add-helm-charts
branch
from
90a6b03
to
f00a568
Compare
anurag4DSB
force-pushed
the
feature/COSI-43-add-smoke-test-for-helm-install
branch
from
3474fbc
to
45f53ae
Compare
|
merging a PR so squashed review commits. rebased an pushed. |
anurag4DSB
force-pushed
the
feature/COSI-33-add-helm-charts
branch
from
f00a568
to
b638c74
Compare
anurag4DSB
force-pushed
the
feature/COSI-43-add-smoke-test-for-helm-install
branch
2 times, most recently
from
e912751
to
0928a24
Compare
|
rebased and pushed to address review comments on the other PR. |
tmacro
approved these changes
Nov 14, 2024
anurag4DSB
force-pushed
the
feature/COSI-43-add-smoke-test-for-helm-install
branch
from
4ced0dd
to
e6cc33e
Compare
scripts affected: - .github/scripts/setup_cosi_resources.sh - .github/scripts/e2e_test_bucket_creation.sh - .github/scripts/capture_k8s_logs.sh - .github/scripts/cleanup_cosi_resources.sh - .github/scripts/verify_helm_install.sh - .github/scripts/wait_for_local_port.bash
anurag4DSB
force-pushed
the
feature/COSI-43-add-smoke-test-for-helm-install
branch
from
e6cc33e
to
39127cb
Compare
anurag4DSB
deleted the
feature/COSI-43-add-smoke-test-for-helm-install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a smoke test for installing the COSI driver using helm chart and update a CI step name