bf: fix possible timeout in unit tests #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas2bert
previously approved these changes
Oct 30, 2017
LaurenSpiegel
previously approved these changes
Oct 30, 2017
|
@ironman-machine try |
|
Hello @nicolas2bert "try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/16560' with the following env. args: {
"SCALITY_INTEGRATION_BRANCH": "ultron/master",
"REPO_NAME": "S3",
"DEFAULT_BRANCH": "master",
"SCALITY_S3_BRANCH": "bf/unitTestsDmdTimeout"
} |
|
☀️ 👍 circleCI test succeeded! |
Prevent S3 unit tests from trying to access a local dmd which is not running, by adding an option to BucketFileInterface constructor not to attempt to open the database. This is only for unit tests that use mocking with BucketFileInterface and should be limited to this use.
jonathan-gramain
force-pushed
the
bf/unitTestsDmdTimeout
branch
from
92816a1
to
78bb24c
Compare
ironman-machine
dismissed stale reviews from nicolas2bert and LaurenSpiegel
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent S3 unit tests from trying to access a local dmd which is not
running, by adding an option to BucketFileInterface constructor not to
attempt to open the database.
This is only for unit tests that use mocking with BucketFileInterface
and should be limited to this use.