metadata: move models to Arsenal #820
Conversation
jeremyds
requested review from
rahulreddy,
LaurenSpiegel,
rachedbenmustapha and
alexandre-merle
| @@ -2,7 +2,7 @@ const assert = require('assert'); | |||
| const { | |||
| WebsiteConfiguration, | |||
| RoutingRule, | |||
| } = require('../../../lib/metadata/WebsiteConfiguration'); | |||
| } require('arsenal').models.websiteconfiguration; | |||
There was a problem hiding this comment.
Is an = missing?
jeremyds
force-pushed
the
dev/models-in-arsenal
branch
from
4cd80b0
to
a2a773e
Compare
jeremyds
force-pushed
the
dev/models-in-arsenal
branch
2 times, most recently
from
684894d
to
ef3eaea
Compare
|
Hello @jeremyds Starting end to end procedure using the following payload: Please follow http://ci.ironmann.io/gh/scality/Integration/14094 for CI status. |
jeremyds
force-pushed
the
dev/models-in-arsenal
branch
from
ef3eaea
to
985887d
Compare
|
Hello @jeremyds Starting end to end procedure using the following payload: Please follow http://ci.ironmann.io/gh/scality/Integration/14097 for CI status. |
|
So, the tests failure are caused by two things:
These two problems are handled in two PRs, in Arsenal and in S3. I will rebase this branch and relaunch the tests once they will be merged. |
The models are the module BucketInfo, ObjectMD, WebsiteConfiguration and ReplicationConfiguration. These models are needed for the S3SOFS feature into the cdmiclient repository. The S3 one does not export modules and shared ones are in Arsenal so move these model modules to it.
rahulreddy
force-pushed
the
dev/models-in-arsenal
branch
from
475aa6a
to
991ec3b
Compare
|
Hello @rahulreddy Starting end to end procedure using the following payload: Please follow http://ci.ironmann.io/gh/scality/Integration/14117 for CI status. |
The models are the module BucketInfo, ObjectMD, WebsiteConfiguration and
ReplicationConfiguration.
These models are needed for the S3SOFS feature into the cdmiclient
repository. The S3 one does not export modules and shared ones are in
Arsenal so move these model modules to it.
Pull request template
Description
Motivation and context
Why is this change required? What problem does it solve?
Related issues
Please use the following link syntaxes #600 to reference issues in the
current repository
Checklist
Add tests to cover the changes
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
Sign your work
In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work
Thank you again for contributing! We will try to test and integrate the change
as soon as we can.