Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Streaming v4 auth extra chunk #737

Merged
merged 4 commits into from
May 19, 2017
Merged

Conversation

LaurenSpiegel
Copy link
Contributor

@LaurenSpiegel LaurenSpiegel commented May 19, 2017

In streaming v4 auth, the last piece is indicated by:
0;chunk-signature=whateversig\r\n\r\n

We were only expecting:
0;chunk-signature=whateversig\r\n

So in the infrequent event when the final '\r\n' was in a separate chunk in the node transform stream, we were doing an unnecessary authentication step which was resulting in a signature mismatch error.

This PR addresses that problem, adds additional logs and cherry-picks a prior streaming v4 refactor that was applied in 6.4

@LaurenSpiegel
Copy link
Contributor Author

@ironman-machine start with this one

@ironman-machine
Copy link
Contributor

Hello @LaurenSpiegel

Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "DEFAULT_BRANCH": "6.3.2.1", "SCALITY_S3_BRANCH": "fix/streamingV4Auth"}

CI message: "Branch not found"

Please follow the last build of 6.3.2.1 for CI status.

Without this change, if a chunk has data that should start with a line
break, we were removing it which causes a signature does not much
error.
@LaurenSpiegel
Copy link
Contributor Author

@ironman-machine try
DEFAULT_BRANCH=GA6.3.2

@ironman-machine
Copy link
Contributor

Hello @LaurenSpiegel

Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "DEFAULT_BRANCH": "GA6.3.2", "SCALITY_S3_BRANCH": "fix/streamingV4Auth"}

CI message: "Branch not found"

Please follow the last build of GA6.3.2 for CI status.

@LaurenSpiegel
Copy link
Contributor Author

@ironman-machine so picky
DEFAULT_BRANCH=rel/6.3

@ironman-machine
Copy link
Contributor

Hello @LaurenSpiegel

Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "DEFAULT_BRANCH": "rel/6.3", "SCALITY_S3_BRANCH": "fix/streamingV4Auth"}

Please follow http://ci.ironmann.io/gh/scality/Integration/13040 for CI status.

@LaurenSpiegel
Copy link
Contributor Author

@ironman-machine with fog gem update
DEFAULT_BRANCH=rel/6.3

@ironman-machine
Copy link
Contributor

Hello @LaurenSpiegel

Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "DEFAULT_BRANCH": "rel/6.3", "SCALITY_S3_BRANCH": "fix/streamingV4Auth"}

Please follow http://ci.ironmann.io/gh/scality/Integration/13041 for CI status.

@LaurenSpiegel
Copy link
Contributor Author

end to end passed here: http://ci.ironmann.io/gh/scality/Integration/13043

@LaurenSpiegel LaurenSpiegel merged commit d94171f into 6.3.2.1 May 19, 2017
@rahulreddy rahulreddy deleted the fix/streamingV4Auth branch August 14, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants