-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
listenOn: Disable IP parsing to allow the usage of FQDNs #600
Conversation
Is there an issue that goes with this? |
Not at the moment, since it was a "on-the-fly-fix" (meaning I made it through experimentation with @xaf-scality) to put the finishing touches to the rc4 |
@DavidPineauScality, if we really need to be able to support FQDNs, let's just get rid of the assertion without the added comment lines. If the listenOn address is incorrect, it seems this will be discovered rather quickly without the assertion. Do you agree? Also, there is a linting error since you are no longer using ipCheck but it is defined. |
Well, more than "really need", it's often easier to remember machines through their fqdns, and as such we tend to configure them when available. |
83f62e4
to
374baab
Compare
374baab
to
2d94268
Compare
rebased + fixed (or should be) |
This patch removes the check of the IP's format, since we want to be able to use FQDNs instead.
Related to our ongoing multi-ports fixes.