Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listenOn: Disable IP parsing to allow the usage of FQDNs #600

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2017

This patch removes the check of the IP's format, since we want to be able to use FQDNs instead.

Related to our ongoing multi-ports fixes.

@ghost ghost assigned vrancurel Feb 8, 2017
@LaurenSpiegel
Copy link
Contributor

Is there an issue that goes with this?

@ghost
Copy link
Author

ghost commented Feb 9, 2017

Not at the moment, since it was a "on-the-fly-fix" (meaning I made it through experimentation with @xaf-scality) to put the finishing touches to the rc4
edit: Do you want me to open one ? (Jira I guess now ?)

@LaurenSpiegel
Copy link
Contributor

@DavidPineauScality, if we really need to be able to support FQDNs, let's just get rid of the assertion without the added comment lines. If the listenOn address is incorrect, it seems this will be discovered rather quickly without the assertion. Do you agree? Also, there is a linting error since you are no longer using ipCheck but it is defined.

@ghost
Copy link
Author

ghost commented Feb 22, 2017

Well, more than "really need", it's often easier to remember machines through their fqdns, and as such we tend to configure them when available.
I'm fine with removing the bit of code altogether, along with the comment (which was mostly there for doc purposes)

@ghost ghost force-pushed the dev/removeListenOnCheck branch from 83f62e4 to 374baab Compare February 22, 2017 19:42
@ghost ghost force-pushed the dev/removeListenOnCheck branch from 374baab to 2d94268 Compare February 22, 2017 19:43
@ghost
Copy link
Author

ghost commented Feb 22, 2017

rebased + fixed (or should be)

@LaurenSpiegel LaurenSpiegel merged commit e2a2574 into rel/6.4 Feb 23, 2017
@LaurenSpiegel LaurenSpiegel deleted the dev/removeListenOnCheck branch February 23, 2017 23:22
@dora-korpar dora-korpar mentioned this pull request May 20, 2017
@nicolas2bert nicolas2bert mentioned this pull request Jul 25, 2017
@nicolas2bert nicolas2bert mentioned this pull request Aug 3, 2017
@dora-korpar dora-korpar mentioned this pull request Aug 17, 2017
@JeffreyBurr JeffreyBurr mentioned this pull request Aug 30, 2017
@ssalaues ssalaues mentioned this pull request Oct 18, 2017
@jeremyds jeremyds mentioned this pull request Dec 2, 2017
This was referenced Sep 21, 2023
This was referenced May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants