Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/cldsrv 531 delete lifecycle ignored #5568

Merged
merged 2 commits into from
May 15, 2024

Conversation

KazToozs
Copy link

Pull request template

Description

Motivation and context

Why is this change required? What problem does it solve?

Related issues

Please use the following link syntaxes #600 to reference issues in the
current repository

Checklist

Add tests to cover the changes

New tests added or existing tests modified to cover all changes

Code conforms with the style guide

Sign your work

In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change
as soon as we can.

@bert-e
Copy link
Contributor

bert-e commented May 14, 2024

Hello kaztoozs,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 14, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

  • None

Considering where you are trying to merge, I expected to find at least:

  • 7.70.21.1

Please check the Fix Version/s of CLDSRV-531, or the target
branch of this pull request.

Copy link
Contributor

@williamlardier williamlardier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: I see no specific way to test this as we already added test for this APi in Integration for 9.3, and we do not test authz in s3 (especially in 7.70...)

@KazToozs KazToozs marked this pull request as ready for review May 15, 2024 09:19
@KazToozs
Copy link
Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 15, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

  • None

Considering where you are trying to merge, I expected to find at least:

  • 7.70.21.1

Please check the Fix Version/s of CLDSRV-531, or the target
branch of this pull request.

The following options are set: approve

@KazToozs
Copy link
Author

/help

@bert-e
Copy link
Contributor

bert-e commented May 15, 2024

Help page

The following options and commands are available at this time.

Options

name description privileged authored
➡️ after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
➡️ bypass_author_approval Bypass the pull request author's approval
➡️ bypass_build_status Bypass the build and test status
➡️ bypass_commit_size Bypass the check on the size of the changeset TBA
➡️ bypass_incompatible_branch Bypass the check on the source branch prefix
➡️ bypass_jira_check Bypass the Jira issue check
➡️ bypass_peer_approval Bypass the pull request peers' approval
➡️ bypass_leader_approval Bypass the pull request leaders' approval
➡️ approve Instruct Bert-E that the author has approved the pull request. ✍️
➡️ create_pull_requests Allow the creation of integration pull requests.
➡️ create_integration_branches Allow the creation of integration branches.
➡️ no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
➡️ unanimity Change review acceptance criteria from one reviewer at least to all reviewers
➡️ wait Instruct Bert-E not to run until further notice.

Commands

name description privileged
➡️ help Print Bert-E's manual in the pull request.
➡️ status Print Bert-E's current status in the pull request TBA
➡️ clear Remove all comments from Bert-E from the history TBA
➡️ retry Re-start a fresh build TBA
➡️ build Re-start a fresh build TBA
➡️ force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
➡️ reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 15, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

  • None

Considering where you are trying to merge, I expected to find at least:

  • 7.70.21.1

Please check the Fix Version/s of CLDSRV-531, or the target
branch of this pull request.

The following options are set: approve

@KazToozs
Copy link
Author

ping

@bert-e
Copy link
Contributor

bert-e commented May 15, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

  • 7.70.21-6

Considering where you are trying to merge, I expected to find at least:

  • 7.70.21.1

Please check the Fix Version/s of CLDSRV-531, or the target
branch of this pull request.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 15, 2024

Not authorized

I'm afraid I cannot do that, @KazToozs:

/bypass_jira_check

You cannot use bypass_jira_check in your own pull request.

Please edit or delete the corresponding comment so I can move on.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 15, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

  • 7.70.21-6

Considering where you are trying to merge, I expected to find at least:

  • 7.70.21.1

Please check the Fix Version/s of CLDSRV-531, or the target
branch of this pull request.

The following options are set: approve

@anurag4DSB
Copy link
Contributor

/bypass_jira_check

@bert-e
Copy link
Contributor

bert-e commented May 15, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/7.70.21

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7
  • development/8.8

Please check the status of the associated issue CLDSRV-531.

Goodbye kaztoozs.

The following options are set: bypass_jira_check, approve

@bert-e bert-e merged commit c2ca912 into hotfix/7.70.21 May 15, 2024
8 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-531-delete-lifecycle-ignored branch May 15, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants