fixup: bucketName source + error if no key field

scality · Jul 9, 2024 · 57f34b9 · 57f34b9
1 parent e9a4300
commit 57f34b9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/api/api.js b/lib/api/api.js
@@ -217,9 +217,13 @@ const api = {
 
                     formDataParser.on('file', (fieldname, file, filename, encoding, mimetype) => {
                         fileEventData = { fieldname, file, filename, encoding, mimetype };
-                        return next(null);
+                        // no key field == error
+                        if ('key' in request.formData) {
+                            return next(null);
+                        }
+                        return next(errors.InvalidArgument.customizeDescription('Bucket POST must contain'
+                            + " a field named 'key'.  If it is specified, please check the order of the fields."));
                     });
-
                     formDataParser.on('finish', () => {
                         // No file field == error
                         if (!fileEventData) {

diff --git a/lib/api/objectPost.js b/lib/api/objectPost.js
@@ -37,14 +37,16 @@ function objectPost(authInfo, request, streamingV4Params, log, callback) {
     const {
         headers,
         method,
+        formData,
+        bucketName,
     } = request;
     let parsedContentLength = 0;
     const passThroughStream = new PassThrough();
     const requestType = request.apiMethods || 'objectPost';
     const valParams = {
         authInfo,
-        bucketName: request.formData.bucket,
-        objectKey: request.formData.key,
+        bucketName,
+        objectKey: formData.key,
         requestType,
         request,
     };