bugfix: S3C-2726 remove some default attributes from ObjectMD #988
Conversation
Remove "nullVersionId", "isNull" and "isDeleteMarker" default values from ObjectMD model, instead of the previous '' (empty string) default value that was incorrect and could cause an issue by misinterpreting the empty "nullVersionId" as an actual null version ID.
Hello jonathan-gramain,My role is to assist you with the merge of this Status report is not available. |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.1/bugfix/S3C-2726-removeSomeDefaultAttributesFromObjectMD origin/development/8.1
$ git merge origin/w/7.7/bugfix/S3C-2726-removeSomeDefaultAttributesFromObjectMD
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.1/bugfix/S3C-2726-removeSomeDefaultAttributesFromObjectMD |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
Follow integration pull requests if you would like to be notified of |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
| 'versionId': undefined, // If no versionId, it should be undefined | ||
| // versionId, isNull, nullVersionId and isDeleteMarker | ||
| // should be undefined when not set explicitly | ||
| 'isNull': undefined, |
There was a problem hiding this comment.
'isNull' and 'isDeleteMarker' are booleans and could be set to false by default?
There was a problem hiding this comment.
I wanted to stay consistent with what cloudserver writes when it puts a new object, which has no such attributes in the metadata.
|
@rahulreddy if you mean by this that the attributes will not be present in the metadata if they are undefined, yes, and it's already the case since those attributes are not set by Cloudserver when they are not needed today (Cloudserver does not use ObjectMD for most parts). |
|
@bert-e approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3C-2726. Goodbye jonathan-gramain. |
bert-e
deleted the
bugfix/S3C-2726-removeSomeDefaultAttributesFromObjectMD
branch
Remove "nullVersionId", "isNull" and "isDeleteMarker" default values
from ObjectMD model, instead of the previous '' (empty string) default
value that was incorrect and could cause an issue by misinterpreting
the empty "nullVersionId" as an actual null version ID.
The original issue as reported in the Jira ticket is tested in a new integration test case: https://github.com/scality/Integration/pull/731