Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: filters out special collections #868

Merged

Conversation

vrancurel
Copy link
Contributor

Exclude collections starting with __
Nevertheless keeping explicit naming on collections
that are used directly by cloudserver even though they start with __
for sake of clarity

@bert-e
Copy link
Contributor

bert-e commented Aug 6, 2019

Hello vrancurel,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 6, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

Create a function to identify special collections.
Exclude collections starting with __ .
Nevertheless keeping explicit naming on collections
that are used directly by cloudserver even though they start with __
for sake of clarity.
Include a unit test.
@vrancurel vrancurel force-pushed the improvement/ZENKO-2045-ignore-special-collections branch from 41d5a88 to 62536f6 Compare August 6, 2019 18:04
@vrancurel
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Aug 6, 2019

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4
  • development/7.5
  • stabilization/7.5.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 6, 2019

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4
  • development/7.5
  • stabilization/7.5.0

Please check the status of the associated issue ZENKO-2045.

Goodbye vrancurel.

@bert-e bert-e merged commit 62536f6 into development/8.1 Aug 6, 2019
@bert-e bert-e deleted the improvement/ZENKO-2045-ignore-special-collections branch August 6, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants