Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft(ZENKO-1616): Update ObjectMD model for azure blob api #766

Conversation

tmacro
Copy link
Contributor

@tmacro tmacro commented Mar 25, 2019

Add fields required for Azure Blob API support

@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2019

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

@tmacro tmacro force-pushed the feature/ZENKO-1616_Update_ObjectMD_model_for_azure_blob_api branch 3 times, most recently from b242123 to 3d4e7cd Compare March 26, 2019 17:44
@tmacro
Copy link
Contributor Author

tmacro commented Mar 26, 2019

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Mar 26, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@tmacro tmacro force-pushed the feature/ZENKO-1616_Update_ObjectMD_model_for_azure_blob_api branch from 3d4e7cd to 00f8277 Compare March 26, 2019 22:26
lib/models/ObjectMD.js Outdated Show resolved Hide resolved
lib/models/ObjectMD.js Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Mar 27, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

The following options are set: approve

@tmacro tmacro force-pushed the feature/ZENKO-1616_Update_ObjectMD_model_for_azure_blob_api branch from 00f8277 to c64a807 Compare March 27, 2019 17:34
@tmacro tmacro requested a review from ploki March 28, 2019 17:53
@tmacro tmacro force-pushed the feature/ZENKO-1616_Update_ObjectMD_model_for_azure_blob_api branch from c64a807 to c772671 Compare March 28, 2019 19:14
@tmacro tmacro requested a review from ploki March 28, 2019 19:49
@bert-e
Copy link
Contributor

bert-e commented Mar 28, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@tmacro tmacro force-pushed the feature/ZENKO-1616_Update_ObjectMD_model_for_azure_blob_api branch from c772671 to 870d895 Compare March 28, 2019 20:56
Copy link
Collaborator

@rahulreddy rahulreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment Object Model version and document the attributes here https://github.com/scality/Arsenal/blob/development/8.1/lib/constants.js#L37

@bert-e
Copy link
Contributor

bert-e commented Mar 28, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

The following options are set: approve

@tmacro tmacro force-pushed the feature/ZENKO-1616_Update_ObjectMD_model_for_azure_blob_api branch from 870d895 to 2d83f88 Compare March 29, 2019 17:28
@tmacro tmacro requested a review from rahulreddy March 29, 2019 17:28
@tmacro tmacro force-pushed the feature/ZENKO-1616_Update_ObjectMD_model_for_azure_blob_api branch from 2d83f88 to 5929051 Compare April 1, 2019 21:08
@bert-e
Copy link
Contributor

bert-e commented Apr 2, 2019

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4
  • development/7.5
  • development/8.0
  • stabilization/7.4.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 2, 2019

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4
  • development/7.5
  • development/8.0
  • stabilization/7.4.3

Please check the status of the associated issue ZENKO-1616.

Goodbye tmacro.

@bert-e bert-e merged commit 5929051 into development/8.1 Apr 2, 2019
@bert-e bert-e deleted the feature/ZENKO-1616_Update_ObjectMD_model_for_azure_blob_api branch May 5, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants