Feature: S3C-1966: KMIP TLS Transport #688

ploki · 2019-02-23T00:14:01Z

No description provided.

bert-e · 2019-02-23T00:14:03Z

Hello ploki,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2019-02-23T00:14:13Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/S3C-1966/kmip-tls-transport into
development/7.5
w/8.0/feature/S3C-1966/kmip-tls-transport will be merged into development/8.0 (pull request INTEGRATION [PR#688 > development/8.0] Feature: S3C-1966: KMIP TLS Transport #689)
w/8.1/feature/S3C-1966/kmip-tls-transport will be merged into development/8.1 (pull request INTEGRATION [PR#688 > development/8.1] Feature: S3C-1966: KMIP TLS Transport #690)

The following branches will NOT be impacted:

development/6.4
development/7.4
stabilization/7.4.3

Follow integration pull requests if you would like to be notified of
build statuses by email.

bert-e · 2019-02-23T00:14:14Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

Peer approvals must include at least 1 approval from the following list:

bert-e · 2019-02-23T00:18:05Z

History mismatch

Merge commit #2b1138aec8424198f63afb2b69fc7bcf6d0e3670 on the integration branch
w/8.0/feature/S3C-1966/kmip-tls-transport is merging a branch which is neither the current
branch feature/S3C-1966/kmip-tls-transport nor the development branch
development/8.0.

It is likely due to a rebase of the branch feature/S3C-1966/kmip-tls-transport and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

bennettbuchanan · 2019-02-27T19:10:45Z

lib/network/kmip/transport/TransportTemplate.js

+    constructor(channel, options) {
+        this.channel = channel;
+        this.options = options;
+        this.pipelineDepth = Math.max(1, options.pipelineDepth ||


Just want to confirm that the 0 case is intended to go to the default rather than the max of 1. For example:

if options.pipelineDepth is < 0 this.pipelineDepth is 1

if options.pipelineDepth is equal to 0 this.pipelineDepth is 8

exact! (actually, 1 is the min)

bennettbuchanan · 2019-02-27T19:31:01Z

tests/unit/kmip/ttlvCodec.js

-    debug: () => {},
-    error: () => {},
-};
+const { logger } = require('../../utils/kmip/ersatz.js');


I like the file name here ✅

ploki · 2019-02-27T19:42:50Z

@bert-e reset

bert-e · 2019-02-27T19:42:57Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2019-02-27T19:43:10Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/S3C-1966/kmip-tls-transport into
development/7.5
w/8.0/feature/S3C-1966/kmip-tls-transport will be merged into development/8.0 (pull request INTEGRATION [PR#688 > development/8.0] Feature: S3C-1966: KMIP TLS Transport #699)
w/8.1/feature/S3C-1966/kmip-tls-transport will be merged into development/8.1 (pull request INTEGRATION [PR#688 > development/8.1] Feature: S3C-1966: KMIP TLS Transport #700)

The following branches will NOT be impacted:

development/6.4
development/7.4
stabilization/7.4.3

Follow integration pull requests if you would like to be notified of
build statuses by email.

bert-e · 2019-02-27T19:43:12Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

Peer approvals must include at least 1 approval from the following list:

bert-e · 2019-02-27T19:44:59Z

Build failed

The build for commit did not succeed in branch w/8.1/feature/S3C-1966/kmip-tls-transport.

The following options are set: approve

ploki · 2019-02-27T22:58:16Z

@bert-e reset

bert-e · 2019-02-27T22:58:24Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

bert-e · 2019-02-27T22:58:35Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/S3C-1966/kmip-tls-transport into
development/7.5
w/8.0/feature/S3C-1966/kmip-tls-transport will be merged into development/8.0 (pull request INTEGRATION [PR#688 > development/8.0] Feature: S3C-1966: KMIP TLS Transport #701)
w/8.1/feature/S3C-1966/kmip-tls-transport will be merged into development/8.1 (pull request INTEGRATION [PR#688 > development/8.1] Feature: S3C-1966: KMIP TLS Transport #702)

The following branches will NOT be impacted:

development/6.4
development/7.4
stabilization/7.4.3

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: approve

bert-e · 2019-02-27T23:00:28Z

Build failed

The build for commit did not succeed in branch w/8.1/feature/S3C-1966/kmip-tls-transport.

The following options are set: approve

bert-e · 2019-02-28T19:04:47Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

Peer approvals must include at least 1 approval from the following list:

bennettbuchanan · 2019-02-28T19:11:56Z

lib/network/kmip/transport/TransportTemplate.js

+    end() {
+        if (this.callbackPipeline.length !== 0 ||
+            this.deferedRequests.length !== 0) {
+            this.pipelineDrainedCallback = this.socket.end.bind(this.socket);


Is there any scenario where this.socket could be null here?

yes, after a misusage of the API during shutdown (calling twice, or race reaping the pending errors).
Good catch, need to be checked

bennettbuchanan

Left one consideration, but LGTM overall! ✅

bert-e · 2019-02-28T19:49:43Z

History mismatch

Merge commit #1189f14bb0d0bdd60c8c9f7b0fc24b3d1be76d4a on the integration branch
w/8.0/feature/S3C-1966/kmip-tls-transport is merging a branch which is neither the current
branch feature/S3C-1966/kmip-tls-transport nor the development branch
development/8.0.

It is likely due to a rebase of the branch feature/S3C-1966/kmip-tls-transport and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

ploki · 2019-02-28T19:49:57Z

@bert-e reset

bert-e · 2019-02-28T19:50:06Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2019-02-28T19:50:18Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/S3C-1966/kmip-tls-transport into
development/7.5
w/8.0/feature/S3C-1966/kmip-tls-transport will be merged into development/8.0 (pull request INTEGRATION [PR#688 > development/8.0] Feature: S3C-1966: KMIP TLS Transport #703)
w/8.1/feature/S3C-1966/kmip-tls-transport will be merged into development/8.1 (pull request INTEGRATION [PR#688 > development/8.1] Feature: S3C-1966: KMIP TLS Transport #704)

The following branches will NOT be impacted:

development/6.4
development/7.4
stabilization/7.4.3

Follow integration pull requests if you would like to be notified of
build statuses by email.

bert-e · 2019-02-28T19:50:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

Peer approvals must include at least 1 approval from the following list:

ploki · 2019-02-28T19:54:50Z

@bert-e approve

bert-e · 2019-02-28T19:55:02Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/7.5
✔️ development/8.0
✔️ development/8.1

The following branches will NOT be impacted:

development/6.4
development/7.4
stabilization/7.4.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2019-02-28T19:55:11Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/7.5
✔️ development/8.0
✔️ development/8.1

The following branches have NOT changed:

development/6.4
development/7.4
stabilization/7.4.3

Please check the status of the associated issue S3C-1966.

Goodbye ploki.

This was referenced Feb 23, 2019

INTEGRATION [PR#688 > development/8.0] Feature: S3C-1966: KMIP TLS Transport #689

Closed

INTEGRATION [PR#688 > development/8.1] Feature: S3C-1966: KMIP TLS Transport #690

Closed

ploki force-pushed the feature/S3C-1966/kmip-tls-transport branch from 2b1138a to 1189f14 Compare February 23, 2019 00:18

ploki requested a review from tmacro February 26, 2019 23:41

tmacro approved these changes Feb 27, 2019

View reviewed changes

ssalaues approved these changes Feb 27, 2019

View reviewed changes

bennettbuchanan approved these changes Feb 27, 2019

View reviewed changes

This was referenced Feb 27, 2019

INTEGRATION [PR#688 > development/8.0] Feature: S3C-1966: KMIP TLS Transport #699

Closed

INTEGRATION [PR#688 > development/8.1] Feature: S3C-1966: KMIP TLS Transport #700

Closed

This was referenced Feb 27, 2019

INTEGRATION [PR#688 > development/8.0] Feature: S3C-1966: KMIP TLS Transport #701

Closed

INTEGRATION [PR#688 > development/8.1] Feature: S3C-1966: KMIP TLS Transport #702

Closed

bennettbuchanan reviewed Feb 28, 2019

View reviewed changes

bennettbuchanan approved these changes Feb 28, 2019

View reviewed changes

feature: S3C-1966: KMIP TLS Transport

b3598c5

ploki force-pushed the feature/S3C-1966/kmip-tls-transport branch from 3b45b3e to b3598c5 Compare February 28, 2019 19:49

This was referenced Feb 28, 2019

INTEGRATION [PR#688 > development/8.0] Feature: S3C-1966: KMIP TLS Transport #703

Merged

INTEGRATION [PR#688 > development/8.1] Feature: S3C-1966: KMIP TLS Transport #704

Merged

bert-e merged commit b3598c5 into development/7.5 Feb 28, 2019

ploki deleted the feature/S3C-1966/kmip-tls-transport branch February 28, 2019 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: S3C-1966: KMIP TLS Transport #688

Feature: S3C-1966: KMIP TLS Transport #688

ploki commented Feb 23, 2019

bert-e commented Feb 23, 2019

bert-e commented Feb 23, 2019

bert-e commented Feb 23, 2019

bert-e commented Feb 23, 2019

bennettbuchanan Feb 27, 2019

ploki Feb 27, 2019

bennettbuchanan Feb 27, 2019

ploki commented Feb 27, 2019

bert-e commented Feb 27, 2019

bert-e commented Feb 27, 2019

bert-e commented Feb 27, 2019

bert-e commented Feb 27, 2019

ploki commented Feb 27, 2019

bert-e commented Feb 27, 2019

bert-e commented Feb 27, 2019

bert-e commented Feb 27, 2019

bert-e commented Feb 28, 2019

bennettbuchanan Feb 28, 2019

ploki Feb 28, 2019

bennettbuchanan left a comment

bert-e commented Feb 28, 2019

ploki commented Feb 28, 2019

bert-e commented Feb 28, 2019

bert-e commented Feb 28, 2019

bert-e commented Feb 28, 2019

ploki commented Feb 28, 2019

bert-e commented Feb 28, 2019

bert-e commented Feb 28, 2019

Feature: S3C-1966: KMIP TLS Transport #688

Feature: S3C-1966: KMIP TLS Transport #688

Conversation

ploki commented Feb 23, 2019

bert-e commented Feb 23, 2019

Hello ploki,

bert-e commented Feb 23, 2019

Integration data created

bert-e commented Feb 23, 2019

Waiting for approval

bert-e commented Feb 23, 2019

History mismatch

bennettbuchanan Feb 27, 2019

Choose a reason for hiding this comment

ploki Feb 27, 2019

Choose a reason for hiding this comment

bennettbuchanan Feb 27, 2019

Choose a reason for hiding this comment

ploki commented Feb 27, 2019

bert-e commented Feb 27, 2019

Reset complete

bert-e commented Feb 27, 2019

Integration data created

bert-e commented Feb 27, 2019

Waiting for approval

bert-e commented Feb 27, 2019

Build failed

ploki commented Feb 27, 2019

bert-e commented Feb 27, 2019

Reset complete

bert-e commented Feb 27, 2019

Integration data created

bert-e commented Feb 27, 2019

Build failed

bert-e commented Feb 28, 2019

Waiting for approval

bennettbuchanan Feb 28, 2019

Choose a reason for hiding this comment

ploki Feb 28, 2019

Choose a reason for hiding this comment

bennettbuchanan left a comment

Choose a reason for hiding this comment

bert-e commented Feb 28, 2019

History mismatch

ploki commented Feb 28, 2019

bert-e commented Feb 28, 2019

Reset complete

bert-e commented Feb 28, 2019

Integration data created

bert-e commented Feb 28, 2019

Waiting for approval

ploki commented Feb 28, 2019

bert-e commented Feb 28, 2019

In the queue

bert-e commented Feb 28, 2019