-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/zenko 1402 move data backends #640
Conversation
Hello dora-korpar,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
445267c
to
e0d4180
Compare
e0d4180
to
801d049
Compare
@bert-e reset |
Reset completeI have successfully deleted this pull request's integration branches. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
801d049
to
d7ca4c1
Compare
package.json
Outdated
@@ -36,6 +39,7 @@ | |||
"socket.io-client": "~2.2.0", | |||
"utf8": "3.0.0", | |||
"uuid": "^3.0.1", | |||
"vaultclient": "scality/vaultclient#754b6e1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We introduce here a circular dependency: only cloudserver shall be able to have vaultclient in its package.json. The vaultclient lib instance shall be passed from cloudserver to Arsenal (just like sproxydclient and bucketclient)
d7ca4c1
to
d0343f2
Compare
where are we now ? |
The vaultclient dependency was removed, and this is ready to go, there are just a few tests failing in CloudServer that I need to verify before merging this |
de00e34
to
ef0a6a9
Compare
ef0a6a9
to
c657b4b
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
@bert-e approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZENKO-1402. Goodbye dora-korpar. |
Beginning the work of moving the data backends to Arsenal.
This PR includes the external backend clients, the necessary supporting functions, and the existing unit tests for both of those.
Most files have simply been copied over (with adjusted requirements). The only code changes beyond requirements have been to
getVault.js
, which was copied over fromvault.js
(https://github.com/scality/cloudserver/blob/development/8.1/lib/auth/vault.js) in CloudServer. In order to circumvent the problem of assuming the use of the CloudServer config, the code was wrapped in a function.The other change is that a config parameter was introduced to several client function, as they too require the CloudServer config.