Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zenko 1402 move data backends #640

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

dora-korpar
Copy link
Contributor

@dora-korpar dora-korpar commented Jan 8, 2019

Beginning the work of moving the data backends to Arsenal.
This PR includes the external backend clients, the necessary supporting functions, and the existing unit tests for both of those.
Most files have simply been copied over (with adjusted requirements). The only code changes beyond requirements have been to getVault.js, which was copied over from vault.js (https://github.com/scality/cloudserver/blob/development/8.1/lib/auth/vault.js) in CloudServer. In order to circumvent the problem of assuming the use of the CloudServer config, the code was wrapped in a function.
The other change is that a config parameter was introduced to several client function, as they too require the CloudServer config.

@bert-e
Copy link
Contributor

bert-e commented Jan 8, 2019

Hello dora-korpar,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 8, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

@dora-korpar
Copy link
Contributor Author

@bert-e reset

@bert-e
Copy link
Contributor

bert-e commented Jan 9, 2019

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Jan 9, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

@dora-korpar dora-korpar force-pushed the feature/ZENKO-1402-move-data-backends branch from 801d049 to d7ca4c1 Compare January 9, 2019 21:46
package.json Outdated
@@ -36,6 +39,7 @@
"socket.io-client": "~2.2.0",
"utf8": "3.0.0",
"uuid": "^3.0.1",
"vaultclient": "scality/vaultclient#754b6e1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We introduce here a circular dependency: only cloudserver shall be able to have vaultclient in its package.json. The vaultclient lib instance shall be passed from cloudserver to Arsenal (just like sproxydclient and bucketclient)

@dora-korpar dora-korpar force-pushed the feature/ZENKO-1402-move-data-backends branch from d7ca4c1 to d0343f2 Compare January 29, 2019 19:49
@vrancurel vrancurel dismissed their stale review January 31, 2019 21:14

will be done potentially in 2 steps

@vrancurel
Copy link
Contributor

where are we now ?

@dora-korpar
Copy link
Contributor Author

The vaultclient dependency was removed, and this is ready to go, there are just a few tests failing in CloudServer that I need to verify before merging this

@dora-korpar dora-korpar force-pushed the feature/ZENKO-1402-move-data-backends branch from de00e34 to ef0a6a9 Compare February 2, 2019 00:05
@dora-korpar dora-korpar force-pushed the feature/ZENKO-1402-move-data-backends branch from ef0a6a9 to c657b4b Compare February 8, 2019 02:03
@bert-e
Copy link
Contributor

bert-e commented Feb 8, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

@dora-korpar
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Feb 8, 2019

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4
  • development/8.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 8, 2019

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4
  • development/8.0

Please check the status of the associated issue ZENKO-1402.

Goodbye dora-korpar.

@bert-e bert-e merged commit c657b4b into development/8.1 Feb 8, 2019
@bert-e bert-e deleted the feature/ZENKO-1402-move-data-backends branch March 31, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants