Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fx: ZENKO-1112 Incomplete management client error logging #558

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

nicolas2bert
Copy link
Contributor

@nicolas2bert nicolas2bert commented Sep 5, 2018

@bert-e
Copy link
Contributor

bert-e commented Sep 5, 2018

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 5, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

@nicolas2bert nicolas2bert force-pushed the bugfix/ZENKO-1112/log branch 2 times, most recently from dda4849 to 8bff327 Compare September 6, 2018 00:53
function reshapeExceptionError(error) {
return {
message: error.message,
code: error.code,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs, some attributes that can be useful to capture are also stack and name.

@bert-e
Copy link
Contributor

bert-e commented Sep 10, 2018

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.0

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of Release Engineering will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of Release Engineering now.

@bert-e
Copy link
Contributor

bert-e commented Sep 10, 2018

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.0

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ZENKO-1112.

Goodbye nicolas2bert.

@bert-e bert-e merged commit 9dca871 into development/8.0 Sep 10, 2018
@rahulreddy rahulreddy deleted the bugfix/ZENKO-1112/log branch September 10, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants