Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ZENKO-632 check if destroy method is available #530

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

rahulreddy
Copy link
Collaborator

@rahulreddy rahulreddy commented Jul 6, 2018

s3-data returns Readable unlike sproxydclient which returns an instance of
http.IncomingMessage which implements Readable stream and extends it with
destroy method

@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2018

Hello rahulreddy,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • 2 peers

s3-data returns Readable unlike sproxydclient which returns an instance of
http.IncomingMessage which implements Readable stream and extends it with
destroy method
@rahulreddy rahulreddy force-pushed the bugfix/ZENKO-632-readable-destroy branch from a9de7af to 1b92427 Compare July 6, 2018 22:30
@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2018

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.0

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of Release Engineering will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of Release Engineering now.

@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2018

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.0

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ZENKO-632.

Goodbye rahulreddy.

@bert-e bert-e merged commit 1b92427 into development/8.0 Jul 6, 2018
@rahulreddy rahulreddy deleted the bugfix/ZENKO-632-readable-destroy branch July 6, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants