Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/zenko 597/transient mongo count #525

Merged
merged 1 commit into from
Jun 30, 2018
Merged

Feature/zenko 597/transient mongo count #525

merged 1 commit into from
Jun 30, 2018

Conversation

alexanderchan-scality
Copy link
Contributor

@alexanderchan-scality alexanderchan-scality commented Jun 29, 2018 •
edited
Loading

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Jun 29, 2018

Hello alexanderchan-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 29, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • 2 peers

@alexanderchan-scality alexanderchan-scality force-pushed the feature/ZENKO-597/transientMongoCount branch from b0f8bfa to 382f72a Compare June 29, 2018 21:09
@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@alexanderchan-scality alexanderchan-scality force-pushed the feature/ZENKO-597/transientMongoCount branch from 382f72a to 58de53a Compare June 30, 2018 03:26
@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@bert-e
Copy link
Contributor

bert-e commented Jun 30, 2018

Conflict

There is a conflict between your branch feature/ZENKO-597/transientMongoCount and the
destination branch development/8.0.

Please resolve the conflict on the feature branch (feature/ZENKO-597/transientMongoCount).

#!bash
 $ git fetch
 $ git checkout origin/feature/ZENKO-597/transientMongoCount
 $ git merge origin/development/8.0
 $ # <intense conflict resolution>
 $ git push origin HEAD:feature/ZENKO-597/transientMongoCount

@alexanderchan-scality alexanderchan-scality force-pushed the feature/ZENKO-597/transientMongoCount branch from 58de53a to 6e3515d Compare June 30, 2018 21:36
@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@bert-e
Copy link
Contributor

bert-e commented Jun 30, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • 2 peers

@alexanderchan-scality alexanderchan-scality mentioned this pull request Jun 30, 2018
Merged
philipyoo
philipyoo previously approved these changes Jun 30, 2018
View reviewed changes
lib/storage/metadata/mongoclient/DataCounter.js Outdated
* @return {undefined}
*/
updateTransientList(newLocations) {
if (newLocations) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can newLocations be an empty object?

lib/storage/metadata/mongoclient/MongoClientInterface.js Outdated
@@ -1304,7 +1341,9 @@ class MongoClientInterface {
isVersioned: !!bucketInfo.getVersioningConfiguration(),
ownerCanonicalId: bucketInfo.getOwner(),
};

const isTransient =
this.config.getLocationConstraint(retBucketInfo.location)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be safe, this.config can be undefined (given how it is set in constructor), so I feel we should check and make sure it is a valid object we have access to here

@alexanderchan-scality alexanderchan-scality force-pushed the feature/ZENKO-597/transientMongoCount branch from 6e3515d to e17333b Compare June 30, 2018 22:11
@ironman-machine ironman-machine dismissed philipyoo’s stale review June 30, 2018 22:11

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@bert-e
Copy link
Contributor

bert-e commented Jun 30, 2018

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.0

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of Release Engineering will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of Release Engineering now.

@bert-e
Copy link
Contributor

bert-e commented Jun 30, 2018

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.0

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ZENKO-597.

Goodbye alexanderchan-scality.

@bert-e bert-e merged commit e17333b into development/8.0 Jun 30, 2018
@rahulreddy rahulreddy deleted the feature/ZENKO-597/transientMongoCount branch June 30, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipyoo philipyoo philipyoo approved these changes

@rahulreddy rahulreddy rahulreddy approved these changes

Assignees
No one assigned
Labels
priority high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexanderchan-scality @bert-e @ironman-machine @rahulreddy @philipyoo