Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bf: fix mongo counter #510

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Conversation

alexanderchan-scality
Copy link
Contributor

@alexanderchan-scality alexanderchan-scality commented Jun 22, 2018

Use of Object object instead of the string object for validating typeof lead to counter not being triggered.

@bert-e
Copy link
Contributor

bert-e commented Jun 22, 2018

Hello alexanderchan-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 22, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • 2 peers

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@bert-e
Copy link
Contributor

bert-e commented Jun 22, 2018

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of Release Engineering will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of Release Engineering now.

@bert-e
Copy link
Contributor

bert-e commented Jun 22, 2018

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.0

Please check the status of the associated issue ZENKO-580.

Goodbye alexanderchan-scality.

@bert-e bert-e merged commit 1af67ff into development/8.0 Jun 22, 2018
@alexanderchan-scality alexanderchan-scality deleted the bugfix/ZENKO-580/fixMongoCounter branch June 27, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants