Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zenko-21: FT: New Route for Prometheus Client #478

Merged
merged 1 commit into from
May 2, 2018

Conversation

anurag4DSB
Copy link
Contributor

@anurag4DSB anurag4DSB commented May 1, 2018

Added new route for Prometheus client: /_/monitoring/metrics
Signed-off-by: anurag4DSB [email protected]

dora-korpar
dora-korpar previously approved these changes May 1, 2018
JianqinWang
JianqinWang previously approved these changes May 1, 2018
@anurag4DSB anurag4DSB requested a review from rahulreddy May 1, 2018 17:50
rahulreddy
rahulreddy previously approved these changes May 1, 2018
@ironman-machine ironman-machine dismissed stale reviews from dora-korpar, JianqinWang, and rahulreddy May 2, 2018 00:08

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

Copy link
Collaborator

@rahulreddy rahulreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the commit message per our guidelines? Something like
ft: ZENKO-21 add prometheus monitoring route

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@rahulreddy rahulreddy merged commit a2ce46d into z/1.0 May 2, 2018
@rahulreddy rahulreddy deleted the ft/Zenko-21/prom-route branch May 2, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants