ft: ZENKO-18: Metadata Proxy Server #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploki
force-pushed
the
ft/ZENKO-18/metadata-proxy-server
branch
from
fb21c78
to
c2a5837
Compare
|
PR has been updated. Reviewers, please be cautious. |
ploki
force-pushed
the
ft/ZENKO-18/metadata-proxy-server
branch
from
c2a5837
to
1c44407
Compare
|
PR has been updated. Reviewers, please be cautious. |
ssalaues
previously approved these changes
Apr 5, 2018
vrancurel
previously approved these changes
Apr 6, 2018
jonathan-gramain
previously approved these changes
Apr 17, 2018
| // Internal routes | ||
|
|
||
| /** | ||
| * Handle routes related to operations on buckets attributes |
There was a problem hiding this comment.
on buckets attributes
| switch (uriComponents.namespace) { | ||
| case adminNamespace: | ||
| return this._adminRoutes(req, res, uriComponents, logger); | ||
| default: // coincidently matches the `default' literal namespace as well |
There was a problem hiding this comment.
Is anything starting with something else than /_/ a default route? (so /default/... but also /foobar/...) It's ok for me just wondering.
ploki
force-pushed
the
ft/ZENKO-18/metadata-proxy-server
branch
from
1c44407
to
c975e59
Compare
ironman-machine
dismissed stale reviews from ssalaues, vrancurel, and jonathan-gramain
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
ploki
force-pushed
the
ft/ZENKO-18/metadata-proxy-server
branch
from
c975e59
to
7c4f32b
Compare
|
PR has been updated. Reviewers, please be cautious. |
|
ploki
force-pushed
the
ft/ZENKO-18/metadata-proxy-server
branch
from
7c4f32b
to
5abca4d
Compare
|
PR has been updated. Reviewers, please be cautious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.