Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ft; add data managed metrics #460

Merged
merged 1 commit into from
Apr 6, 2018
Merged

ft; add data managed metrics #460

merged 1 commit into from
Apr 6, 2018

Conversation

alexanderchan-scality
Copy link
Contributor

@alexanderchan-scality alexanderchan-scality commented Apr 3, 2018 •
edited
Loading

Adds total data managed information to the countItems method.

structure of data managed object:

{
    objects: 10,
    versions: 100,
    buckets: 1,
    bucketList: [...]
    dataManaged: {
        total: { curr: 1024, prev: 128 },
        backend-site-1: { curr: 512, prev: 64 }
        (...)
    }
}

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

1 similar comment
@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor 

CONFLICT (content): Merge conflict in lib/storage/metadata/mongoclient/MongoClientInterface.js

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor 

CONFLICT (content): Merge conflict in lib/storage/metadata/mongoclient/MongoClientInterface.js

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

dora-korpar
dora-korpar previously approved these changes Apr 4, 2018
View reviewed changes
@ironman-machine ironman-machine dismissed dora-korpar’s stale review April 4, 2018 17:22

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

dora-korpar
dora-korpar previously approved these changes Apr 4, 2018
View reviewed changes
@rachedbenmustapha
Copy link
Contributor

@alexanderchan-scality after reflexion, since it feels strange to ban the name total, I suggest that the structure would be instead:

dataManaged: {
    total: { curr: 1024, prev: 128 },
    by-location: {
        backend-site-1: { curr: 512, prev: 64 },
        ...
    }
}

@ironman-machine ironman-machine dismissed dora-korpar’s stale review April 4, 2018 22:32

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

rachedbenmustapha
rachedbenmustapha requested changes Apr 5, 2018
View reviewed changes
lib/storage/metadata/mongoclient/MongoClientInterface.js Outdated
/* eslint-disable quote-props*/
dataManaged: {
total: { curr: 0, prev: 0 },
'by-location': {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this upsets the linter, let's just call it byLocation

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine ironman-machine dismissed rachedbenmustapha’s stale review April 5, 2018 17:17

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@rahulreddy rahulreddy merged commit f633b91 into master Apr 6, 2018
@rahulreddy rahulreddy deleted the ft/add-data-managed branch April 6, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dora-korpar dora-korpar dora-korpar approved these changes

@rachedbenmustapha rachedbenmustapha rachedbenmustapha approved these changes

@rahulreddy rahulreddy Awaiting requested review from rahulreddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexanderchan-scality @ironman-machine @rachedbenmustapha @dora-korpar @rahulreddy