Fix/stopSwallowingErrors #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR has been updated. Reviewers, please be cautious. |
|
how can we be sure that S3 passes the mongo test ? |
|
@vrancurel I opened a pr in s3 to run the tests with this branch -- |
vrancurel
previously approved these changes
Feb 13, 2018
ssalaues
previously approved these changes
Feb 13, 2018
LaurenSpiegel
force-pushed
the
fix/replaceUpdate
branch
from
4a40c5b
to
04de7f6
Compare
ironman-machine
dismissed stale reviews from vrancurel and ssalaues
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
LaurenSpiegel
force-pushed
the
fix/replaceUpdate
branch
from
04de7f6
to
586bf95
Compare
|
PR has been updated. Reviewers, please be cautious. |
vrancurel
previously approved these changes
Feb 14, 2018
LaurenSpiegel
force-pushed
the
fix/replaceUpdate
branch
from
586bf95
to
be442d3
Compare
ironman-machine
dismissed
vrancurel’s stale review
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
LaurenSpiegel
force-pushed
the
fix/replaceUpdate
branch
from
be442d3
to
d7cf5e8
Compare
|
PR has been updated. Reviewers, please be cautious. |
|
tests in s3 passed using this branch-- scality/cloudserver#1119 |
vrancurel
approved these changes
Feb 14, 2018
JianqinWang
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.