Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to newer azure SDK #2048

Merged
merged 6 commits into from
Dec 16, 2022
Merged

Migrate to newer azure SDK #2048

merged 6 commits into from
Dec 16, 2022

Conversation

francoisferrand
Copy link
Contributor

@francoisferrand francoisferrand commented Nov 23, 2022 •
edited
Loading

  • Upgrade azure sdk
  • Fix yarn warning
  • Use new url parser in mongoclient
  • Cleanup errorWrapper to better fit with promise-based API used by the new SDK

Note:

Issue: ARSN-281

@bert-e
Copy link
Contributor

bert-e commented Nov 23, 2022

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@francoisferrand francoisferrand requested review from nicolas2bert, a team, watsaqat and tmacro and removed request for a team December 2, 2022 13:55
@francoisferrand francoisferrand force-pushed the improvement/ARSN-281 branch 2 times, most recently from 4371d38 to 937615e Compare December 15, 2022 17:18
@francoisferrand
Upgrade azure sdk
1a63401 
There are a few caveats:
* The `proxy.certs` param is not used anymore (though looking at old SDK
code it may not have been supported already)
* `azureStreamingOptions/options` parameters have not been updated. The
old options (`range` and `DateUnModifiedSince`) are still used and
supported, to avoid compatibility issues.

Issue: ARSN-281
@francoisferrand
Fix yarn warning
2a07f67 
Issue: ARSN-281
@francoisferrand
Use new url parser in mongoclient
81cd665 
This fixes a warning in logs. Old parser is deprecated, and will be
removed at some point.

Issue: ARSN-281
@francoisferrand
AzureClient : Cleanup _errorWrapper
66c4bc5 
Make better use of async and simplify error handling.

Issue: ARSN-281
@francoisferrand
Fix mpu block id
a4f4c51 
it must be base64-encoded in new azure API.

Issue: ARSN-281
@francoisferrand
Fix commit blocks list
7910792
@scality scality deleted a comment from bert-e Dec 16, 2022
@scality scality deleted a comment from bert-e Dec 16, 2022
@bert-e
Copy link
Contributor

bert-e commented Dec 16, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Dec 16, 2022
@francoisferrand
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 16, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 16, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-281.

Goodbye francoisferrand.

@bert-e bert-e merged commit 7910792 into development/8.1 Dec 16, 2022
@bert-e bert-e deleted the improvement/ARSN-281 branch December 16, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerkesni Kerkesni Kerkesni approved these changes

@tmacro tmacro tmacro approved these changes

@nicolas2bert nicolas2bert Awaiting requested review from nicolas2bert

@watsaqat watsaqat Awaiting requested review from watsaqat watsaqat was automatically assigned from scality/object

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francoisferrand @bert-e @tmacro @Kerkesni