INTEGRATION [PR#1989 > development/8.1] bugfix: ARSN-255 revamp evaluatePolicy logic for tag conditions #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn 'const' function objects into actual functions.
Rethink the logic of tag condition evaluation, so that the "evaluateAllPolicies" function appropriately returns the verdict: Allow or Deny or NeedTagConditionEval, the latter being when tag values (request and/or object tags) are needed to settle the verdict to Allow or Deny, in which case, Cloudserver knows it has to resend the request to Vault along with tag info.
…nto tmp/octopus/w/8.1/bugfix/ARSN-255-revampEvaluatePolicyForTagConditions
Codecov Report
@@ Coverage Diff @@
## development/8.1 #1990 +/- ##
===================================================
+ Coverage 63.54% 63.62% +0.07%
===================================================
Files 206 206
Lines 15582 15597 +15
Branches 3166 3176 +10
===================================================
+ Hits 9902 9924 +22
+ Misses 5664 5657 -7
Partials 16 16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bert-e
deleted the
w/8.1/bugfix/ARSN-255-revampEvaluatePolicyForTagConditions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #1989.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/bugfix/ARSN-255-revampEvaluatePolicyForTagConditions, please follow thisprocedure:
$ git fetch $ git checkout w/8.1/bugfix/ARSN-255-revampEvaluatePolicyForTagConditions $ # <amend or cancel the changeset by _adding_ new commits> $ git push origin w/8.1/bugfix/ARSN-255-revampEvaluatePolicyForTagConditionsPlease always comment pull request #1989 instead of this one.