Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aws-sdk to 2.1005+ #1941

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Bump aws-sdk to 2.1005+ #1941

merged 2 commits into from
Jul 6, 2022

Conversation

francoisferrand
Copy link
Contributor

Use same spec as other packages (utapi, vault...), and allow automatic
version bump (dependabot).

Issue: ARSN-234

@francoisferrand francoisferrand marked this pull request as draft June 29, 2022 09:58
@francoisferrand francoisferrand force-pushed the improvement/ARSN-234 branch 13 times, most recently from 5446405 to a735e44 Compare June 29, 2022 16:39
@francoisferrand
Bump aws-sdk to 2.1005+
9b8f9f8 
Use same spec as other packages (utapi, vault...), and allow automatic
version bump (dependabot).

Issue: ARSN-234
@francoisferrand
Copy link
Contributor Author

/create_pull_requests

@francoisferrand francoisferrand marked this pull request as ready for review June 30, 2022 13:13
Base automatically changed from improvement/ARSN-233 to development/7.10 June 30, 2022 14:00
@bert-e
Copy link
Contributor

bert-e commented Jun 30, 2022

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e bert-e mentioned this pull request Jun 30, 2022
Closed
@bert-e
Copy link
Contributor

bert-e commented Jun 30, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests

@scality scality deleted a comment from bert-e Jun 30, 2022
@francoisferrand francoisferrand force-pushed the improvement/ARSN-234 branch 4 times, most recently from 2b448b0 to f5c540f Compare July 1, 2022 13:47
@francoisferrand
Remove check with empty bucket name
a206b5f 
This test is not relevant, since a bucket cannot have an empty name;
and there is now a check in AWS SDK which rejects the request directly.

Issue: ARSN-234
@scality scality deleted a comment from bert-e Jul 1, 2022
@scality scality deleted a comment from bert-e Jul 1, 2022
@scality scality deleted a comment from bert-e Jul 1, 2022
@bert-e bert-e mentioned this pull request Jul 1, 2022
Merged
@bert-e
Copy link
Contributor

bert-e commented Jul 1, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jul 1, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests

@scality scality deleted a comment from bert-e Jul 1, 2022
@francoisferrand
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Jul 6, 2022
@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: create_pull_requests, approve

@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ARSN-234.

Goodbye francoisferrand.

@bert-e bert-e merged commit a206b5f into development/7.10 Jul 6, 2022
@bert-e bert-e deleted the improvement/ARSN-234 branch July 6, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderchan-scality alexanderchan-scality alexanderchan-scality approved these changes

@nicolas2bert nicolas2bert nicolas2bert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francoisferrand @bert-e @nicolas2bert @alexanderchan-scality