-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/arsn 178 introduce x amz restore header #1855
Feature/arsn 178 introduce x amz restore header #1855
Conversation
79f616f
to
642ef25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Hello williamlardier,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
642ef25
to
0e1b895
Compare
Codecov Report
@@ Coverage Diff @@
## development/8.1 #1855 +/- ##
===================================================
+ Coverage 62.99% 63.08% +0.08%
===================================================
Files 199 200 +1
Lines 15391 15428 +37
Branches 3061 3068 +7
===================================================
+ Hits 9696 9733 +37
Misses 5694 5694
Partials 1 1
Continue to review full report at Codecov.
|
2a4322a
to
2fecb99
Compare
158cf7d
to
f8881ef
Compare
f8881ef
to
25ae7e4
Compare
Hi @rachedbenmustapha , I am approving our Arsenal PRs with @XinLiScality , so we can progress. Please let me know if you see a logical change that is required, we will take care of it as part of our work. Thanks! |
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-178. Goodbye williamlardier. |
Introduce the new
x-amz-restore
header based on Fujifilm contributions. I added a note in the file owned by its creator.The new header is introduced as a new class. In order to be able to set the object MD with an object or a class object, I introduced the
isValid
static function that will ensure the provided object is valid, i.e., that its fields are of the right type.