Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/arsn 178 introduce x amz restore header #1855

Merged

Conversation

williamlardier
Copy link
Contributor

Introduce the new x-amz-restore header based on Fujifilm contributions. I added a note in the file owned by its creator.

The new header is introduced as a new class. In order to be able to set the object MD with an object or a class object, I introduced the isValid static function that will ensure the provided object is valid, i.e., that its fields are of the right type.

@williamlardier williamlardier force-pushed the feature/ARSN-178-introduce-x-amz-restore-header branch 2 times, most recently from 79f616f to 642ef25 Compare May 3, 2022 13:59
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Base automatically changed from feature/ARSN-179-support-restore-object to development/8.1 May 5, 2022 10:37
@bert-e
Copy link
Contributor

bert-e commented May 5, 2022

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 5, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@williamlardier williamlardier force-pushed the feature/ARSN-178-introduce-x-amz-restore-header branch from 642ef25 to 0e1b895 Compare May 5, 2022 12:37
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #1855 (3388de6) into development/8.1 (e37712e) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           development/8.1    #1855      +/-   ##
===================================================
+ Coverage            62.99%   63.08%   +0.08%     
===================================================
  Files                  199      200       +1     
  Lines                15391    15428      +37     
  Branches              3061     3068       +7     
===================================================
+ Hits                  9696     9733      +37     
  Misses                5694     5694              
  Partials                 1        1              
Impacted Files Coverage Δ
lib/models/ObjectMD.js 90.02% <100.00%> (+0.30%) ⬆️
lib/models/ObjectMDAmzRestore.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37712e...3388de6. Read the comment docs.

@williamlardier williamlardier force-pushed the feature/ARSN-178-introduce-x-amz-restore-header branch from 2a4322a to 2fecb99 Compare May 6, 2022 07:55
@williamlardier williamlardier force-pushed the feature/ARSN-178-introduce-x-amz-restore-header branch 2 times, most recently from 158cf7d to f8881ef Compare May 9, 2022 14:00
@williamlardier williamlardier force-pushed the feature/ARSN-178-introduce-x-amz-restore-header branch from f8881ef to 25ae7e4 Compare May 9, 2022 14:45
@williamlardier
Copy link
Contributor Author

Hi @rachedbenmustapha , I am approving our Arsenal PRs with @XinLiScality , so we can progress. Please let me know if you see a logical change that is required, we will take care of it as part of our work. Thanks!

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 13, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 13, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-178.

Goodbye williamlardier.

@bert-e bert-e merged commit 75f0744 into development/8.1 May 13, 2022
@bert-e bert-e deleted the feature/ARSN-178-introduce-x-amz-restore-header branch May 13, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants