Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ARSN-154 add support for s3:ObjectTagging notifications #1800

Merged

Conversation

Kerkesni
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Apr 19, 2022

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 19, 2022

Incorrect fix version

The Fix Version/s in issue ARSN-154 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.42

Please check the Fix Version/s of ARSN-154, or the target
branch of this pull request.

@Kerkesni Kerkesni force-pushed the feature/ARSN-154-support-object-tagging-notifications branch from 80b12cc to 7477b88 Compare April 19, 2022 13:50
@bert-e
Copy link
Contributor

bert-e commented Apr 19, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov-commenter
Copy link

Codecov Report

Merging #1800 (7477b88) into development/8.1 (fac5605) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           development/8.1    #1800   +/-   ##
================================================
  Coverage            62.45%   62.45%           
================================================
  Files                  195      195           
  Lines                15242    15242           
  Branches              2994     2994           
================================================
  Hits                  9520     9520           
  Misses                5722     5722           
Impacted Files Coverage Δ
lib/constants.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac5605...7477b88. Read the comment docs.

@Kerkesni Kerkesni requested review from williamlardier, francoisferrand, jbertran, a team and KillianG and removed request for a team April 20, 2022 08:16
Copy link
Contributor

@williamlardier williamlardier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kerkesni
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 20, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 20, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-154.

Goodbye kerkesni.

@bert-e bert-e merged commit 68ac02a into development/8.1 Apr 20, 2022
@bert-e bert-e deleted the feature/ARSN-154-support-object-tagging-notifications branch April 20, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants