Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: arsn 116 fix listing master returning phd #1758

Merged

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Mar 22, 2022

When the last version of an object is deleted a placeholder master key is created and is kept for 15 seconds before it gets repaired.

To avoid listing the PHD keys we added a transform stream that replaces PHD master keys with the last version of that object

For ease of readability, the internal listing function was divided into two functions one for each bucket version format

@bert-e
Copy link
Contributor

bert-e commented Mar 22, 2022

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 22, 2022

Incorrect fix version

The Fix Version/s in issue ARSN-116 contains:

  • 8.1.36

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.38

Please check the Fix Version/s of ARSN-116, or the target
branch of this pull request.

@Kerkesni Kerkesni force-pushed the bugfix/ARSN-116-fix-listing-master-returning-phd branch 2 times, most recently from 3cb4405 to 61dac8e Compare March 22, 2022 13:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1758 (3950018) into development/8.1 (3528c24) will increase coverage by 0.01%.
The diff coverage is 66.10%.

@@                 Coverage Diff                 @@
##           development/8.1    #1758      +/-   ##
===================================================
+ Coverage            62.27%   62.28%   +0.01%     
===================================================
  Files                  195      195              
  Lines                14963    15006      +43     
  Branches              2989     2991       +2     
===================================================
+ Hits                  9318     9347      +29     
- Misses                5645     5659      +14     
Impacted Files Coverage Δ
...orage/metadata/mongoclient/MongoClientInterface.js 66.95% <66.10%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3528c24...3950018. Read the comment docs.

@Kerkesni Kerkesni force-pushed the bugfix/ARSN-116-fix-listing-master-returning-phd branch 2 times, most recently from 8d48389 to 3f83ba0 Compare March 25, 2022 09:24
When the last version of an object is deleted
a placeholder master key is created and is kept
for 15 seconds before it gets repaired.

To avoid listing the PHD keys we added a transform
stream that replaces PHD master keys with the last
version of that object

Added tests for PHD cases + fixed unit tests
@Kerkesni Kerkesni force-pushed the bugfix/ARSN-116-fix-listing-master-returning-phd branch from 3f83ba0 to d46301b Compare March 25, 2022 09:32
@Kerkesni
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2022

Incorrect fix version

The Fix Version/s in issue ARSN-116 contains:

  • 8.1.36

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.38

Please check the Fix Version/s of ARSN-116, or the target
branch of this pull request.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • stabilization/7.10.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • stabilization/7.10.3

Please check the status of the associated issue ARSN-116.

Goodbye kerkesni.

@bert-e bert-e merged commit de17f22 into development/8.1 Mar 25, 2022
@bert-e bert-e deleted the bugfix/ARSN-116-fix-listing-master-returning-phd branch March 25, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants