-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: arsn 116 fix listing master returning phd #1758
Bugfix: arsn 116 fix listing master returning phd #1758
Conversation
Hello kerkesni,My role is to assist you with the merge of this Status report is not available. |
3cb4405
to
61dac8e
Compare
Codecov Report
@@ Coverage Diff @@
## development/8.1 #1758 +/- ##
===================================================
+ Coverage 62.27% 62.28% +0.01%
===================================================
Files 195 195
Lines 14963 15006 +43
Branches 2989 2991 +2
===================================================
+ Hits 9318 9347 +29
- Misses 5645 5659 +14
Continue to review full report at Codecov.
|
8d48389
to
3f83ba0
Compare
When the last version of an object is deleted a placeholder master key is created and is kept for 15 seconds before it gets repaired. To avoid listing the PHD keys we added a transform stream that replaces PHD master keys with the last version of that object Added tests for PHD cases + fixed unit tests
3f83ba0
to
d46301b
Compare
/approve |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-116. Goodbye kerkesni. |
When the last version of an object is deleted a placeholder master key is created and is kept for 15 seconds before it gets repaired.
To avoid listing the PHD keys we added a transform stream that replaces PHD master keys with the last version of that object
For ease of readability, the internal listing function was divided into two functions one for each bucket version format