Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft(ARSN-75): Add support for AbortMPU PUT #1730

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

tmacro
Copy link
Contributor

@tmacro tmacro commented Feb 23, 2022

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Feb 23, 2022

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@tmacro tmacro force-pushed the feature/ARSN-75/support_abortmpu_put branch from 74140c2 to 1bafcd4 Compare February 23, 2022 18:15
@scality scality deleted a comment from bert-e Feb 23, 2022
@bert-e
Copy link
Contributor

bert-e commented Feb 23, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #1730 (71bba12) into development/8.1 (51c5247) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           development/8.1    #1730      +/-   ##
===================================================
- Coverage            60.16%   60.15%   -0.02%     
===================================================
  Files                  192      192              
  Lines                12254    12259       +5     
===================================================
+ Hits                  7373     7374       +1     
- Misses                4881     4885       +4     
Impacted Files Coverage Δ
lib/storage/metadata/file/BucketFileInterface.js 5.34% <0.00%> (-0.06%) ⬇️
lib/storage/metadata/in_memory/metastore.js 59.39% <33.33%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c5247...71bba12. Read the comment docs.

Copy link
Contributor

@jonathan-gramain jonathan-gramain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same minor comment than for scality/cloudserver#4275

@scality scality deleted a comment from bert-e Feb 24, 2022
@tmacro tmacro force-pushed the feature/ARSN-75/support_abortmpu_put branch from 71bba12 to 9a4bae4 Compare February 24, 2022 18:15
@tmacro
Copy link
Contributor Author

tmacro commented Feb 24, 2022

/reset

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2022

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@tmacro
Copy link
Contributor Author

tmacro commented Feb 24, 2022

/approve

@scality scality deleted a comment from bert-e Feb 24, 2022
@tcarmet
Copy link
Contributor

tcarmet commented Feb 24, 2022

ping

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-75.

Goodbye tmacro.

@bert-e bert-e merged commit 6bb68ee into development/8.1 Feb 24, 2022
@bert-e bert-e deleted the feature/ARSN-75/support_abortmpu_put branch February 24, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants