Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/arsn 24 revert arsn 24 use azure storage 2.10.3 #1590

Conversation

naren-rajendran
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Oct 12, 2021

Hello naren-rajendran,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 12, 2021

Incorrect fix version

The Fix Version/s in issue ARSN-24 contains:

  • 8.1.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.5

Please check the Fix Version/s of ARSN-24, or the target
branch of this pull request.

@naren-rajendran
Copy link
Contributor Author

@bert-e reset

@bert-e
Copy link
Contributor

bert-e commented Oct 12, 2021

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Oct 12, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov-commenter
Copy link

Codecov Report

Merging #1590 (2e6b179) into development/8.1 (6a250fe) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           development/8.1    #1590      +/-   ##
===================================================
- Coverage            59.01%   58.82%   -0.20%     
===================================================
  Files                  185      185              
  Lines                11887    11887              
===================================================
- Hits                  7015     6992      -23     
- Misses                4872     4895      +23     
Impacted Files Coverage Δ
lib/storage/data/external/AwsClient.js 25.92% <0.00%> (-8.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a250fe...2e6b179. Read the comment docs.

@rahulreddy
Copy link
Collaborator

/bypass_peer_approval

@bert-e
Copy link
Contributor

bert-e commented Oct 12, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: bypass_peer_approval

@naren-rajendran
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 12, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: bypass_peer_approval, approve

@bert-e
Copy link
Contributor

bert-e commented Oct 12, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-24.

Goodbye naren-rajendran.

@bert-e bert-e merged commit 2e6b179 into development/8.1 Oct 12, 2021
@bert-e bert-e deleted the improvement/ARSN-24-revert-arsn-24-use-azure-storage-2-10-3 branch October 12, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants